You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/07 15:19:08 UTC
[GitHub] [airflow] eladkal opened a new pull request, #23559: Fix `PythonVirtualenvOperator` templated_fields
eladkal opened a new pull request, #23559:
URL: https://github.com/apache/airflow/pull/23559
The `PythonVirtualenvOperator` templated_fields override `PythonOperator` templated_fields which caused functionality not to work as expected.
fixes: https://github.com/apache/airflow/issues/23557
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #23559: Fix `PythonVirtualenvOperator` templated_fields
Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #23559:
URL: https://github.com/apache/airflow/pull/23559#discussion_r868039292
##########
airflow/operators/python.py:
##########
@@ -327,7 +327,13 @@ class PythonVirtualenvOperator(PythonOperator):
processing templated fields, for examples ``['.sql', '.hql']``
"""
- template_fields: Sequence[str] = ('requirements',)
+ template_fields: Sequence[str] = tuple(
+ {
+ 'requirements',
+ }
+ | set(PythonOperator.template_fields)
+ )
Review Comment:
```suggestion
template_fields: Sequence[str] = tuple({"requirements"} | set(PythonOperator.template_fields))
```
I think the comma in the first set is making black format the code strangely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23559: Fix `PythonVirtualenvOperator` templated_fields
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23559:
URL: https://github.com/apache/airflow/pull/23559#issuecomment-1121132715
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23559: Fix `PythonVirtualenvOperator` templated_fields
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23559:
URL: https://github.com/apache/airflow/pull/23559#issuecomment-1121132712
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #23559: Fix `PythonVirtualenvOperator` templated_fields
Posted by GitBox <gi...@apache.org>.
eladkal merged PR #23559:
URL: https://github.com/apache/airflow/pull/23559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org