You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by gadLinux <gi...@git.apache.org> on 2017/03/06 18:00:12 UTC
[GitHub] thrift pull request #1208: THRIFT-4108 : Fix several problems found on libra...
GitHub user gadLinux opened a pull request:
https://github.com/apache/thrift/pull/1208
THRIFT-4108 : Fix several problems found on library.
Adjust headers.
Format code.
Make sure finalization is correct.
Fix convenience methods.
Remove global ssl context.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gadLinux/thrift THRIFT-4108
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1208
----
commit 2923765c56e95b1fe93339cc99d8bf7b357f5295
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date: 2017-03-06T17:55:44Z
Remove global ssl context.
Adjust headers.
Format code.
Make sure finalization is correct.
Fix convenience methods.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1208: THRIFT-4108 : Fix several problems found on libra...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.
Posted by gadLinux <gi...@git.apache.org>.
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1208
@jeking3 This was closed but not merged? Why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.
Posted by gadLinux <gi...@git.apache.org>.
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1208
I added also some documentation and missing include functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1208
It was merged. Pull master and look at the log. When your commit is merged into master I have to amend the commit with "This closes #...." which changes the commit hash, so git may tell you when you attempt to delete the branch that it hasn't been fully merged, but it has.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1208
The careful reader will notice that it says "asfgit closed this in b79396f 19 hours ago". The b79396f is a link to the commit you are looking for.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---