[GitHub] [pulsar] lhotari commented on a change in pull request #9286: Fix flaky MessageIdTest and introduce some testing improvements

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #9286:
URL: https://github.com/apache/pulsar/pull/9286#discussion_r562738608



##########
File path: pulsar-io/hbase/pom.xml
##########
@@ -70,12 +70,6 @@
             <version>${hbase.version}</version>
         </dependency>
 
-        <dependency>

Review comment:
       yes I cherry-picked it since the fix for the broken master branch wasn't merged yet when I pushed this PR. I'll rebase (the commit would get remove) this PR.

##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##########
@@ -408,7 +408,7 @@ public void initializeFailed(ManagedLedgerException e) {
                         pendingLedger.ledger.asyncClose(new CloseCallback() {
                             @Override
                             public void closeComplete(Object ctx) {
-                                // no-op
+                                log.info("[{}] Closed pending initializer managed ledger.", name);

Review comment:
       good catch, I'll fix it.

##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##########
@@ -512,6 +512,7 @@ public void shutdown() throws InterruptedException, ManagedLedgerException {
             ledger.asyncClose(new AsyncCallbacks.CloseCallback() {
                 @Override
                 public void closeComplete(Object ctx) {
+                    log.info("[{}] Closed managed ledger.", ledger.getName());

Review comment:
       good catch, I'll fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org