[GitHub] [tvm] mbs-octoml commented on a change in pull request #9848: [Relay] [Virtual Device] Store function result virtual device in virtual_device_ field

[GitBox <gi...@apache.org>]

mbs-octoml commented on a change in pull request #9848:
URL: https://github.com/apache/tvm/pull/9848#discussion_r802907310



##########
File path: src/parser/parser.cc
##########
@@ -1130,16 +1146,25 @@ class Parser {
         ret_type = ParseType();
       }
 
+      ObjectRef virtual_device;
+      if (WhenMatch(TokenType::kComma)) {
+        virtual_device = ParseVirtualDevice();

Review comment:
       Ideal would be if we could parse the attributes as usual, then 'promote' the "virtual_device" attribute to the first class field. Since meta references are handled by ParseAttributeValue I think that would work out.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org