You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 18:33:36 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #323: Fix undefined behavior in FFI

alamb commented on a change in pull request #323:
URL: https://github.com/apache/arrow-rs/pull/323#discussion_r637123890



##########
File path: .github/workflows/rust.yml
##########
@@ -259,8 +259,9 @@ jobs:
           export MIRIFLAGS="-Zmiri-disable-isolation"
           cargo miri setup
           cargo clean
-          # Ignore MIRI errors until we can get a clean run
-          cargo miri test || true
+          # Currently only the arrow crate is tested with miri 
+          # IO related tests and some unsupported tests are skipped
+          cargo miri test -p arrow -- --skip csv --skip ipc --skip json

Review comment:
       this is epic. Nice work @roee88 !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org