[jira] [Comment Edited] (MNG-6547) MavenProject.writeModel(Writer writer) outputs an error-sorted pom.xml

["Bo Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732910#comment-16732910 ] 

Bo Wang edited comment on MNG-6547 at 1/3/19 11:01 AM:
-------------------------------------------------------

Thanks for your reply.

First, the order dose actually meters the correctness. As I marked in the description, the rewrote pom.xml cannot pass *mvn test* while the original version can pass.

Second, as shown in [^Rewriter.java], this program just reads a pom.xml and then directly writes down, without any modification. The result shows they are actually different. (All the resources are attached and it is easy to reproduce the bug.)


was (Author: wangbo_pku_15):
Thanks for your reply.

First, the order dose actually meters the correctness. As I marked in the description, the rewrote pom.xml cannot pass *mvn test* while the original version can pass.

Second, as shown in [^Rewriter.java], this program just reads a pom.xml and then directly writes, without any modification. The result shows they are actually different. (All the resources are attached and it is easy to reproduce the bug.)

> MavenProject.writeModel(Writer writer) outputs an error-sorted pom.xml 
> -----------------------------------------------------------------------
>
>                 Key: MNG-6547
>                 URL: https://issues.apache.org/jira/browse/MNG-6547
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.5.0, 3.6.0
>         Environment: java version "1.7.0_79"
> Java(TM) SE Runtime Environment (build 1.7.0_79-b15)
> Java HotSpot(TM) 64-Bit Server VM (build 24.79-b02, mixed mode)
>            Reporter: Bo Wang
>            Assignee: Robert Scholte
>            Priority: Major
>         Attachments: Rewriter.java, pom.xml
>
>
> When I try to rewrite a _pom.xml_ to add a plugin configuration via *MavenProject.write(Writer writer)*, the method outputs a wrong pom.xml, which triggers error of *com.google.code.sortpom:maven-sortpom-plugin:2.1.0:verify (verify-sorted-pom).*
> I diff the pom.xml files and find that the order of the two tags *<phase>* and *<goals>* is changed, i.e.:
> *The original section:*
> <execution>
>  <id>generate-thrift</id>
>  *<goals>**...**</goals>*
>  *<phase>*generate-sources</phase>**
>  ...
>  </execution>
> *The error output:*
> <execution>
>  <id>generate-thrift</id>
>  *<phase>*generate-sources</phase>**
>  *<goals>**...**</goals>*
>  ...
>  </execution>
>  
> The tested _[pom.xml|https://github.com/apache/accumulo/blob/1.5.1/trace/pom.xml]_ is a copy from _[accumo-trace|https://github.com/apache/accumulo/tree/1.5.1/trace]_ v1.5.1. The simple bug-trigger code example _[^Rewriter.java] and the tested [^pom.xml]_ are attached. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)