You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Ovilia (via GitHub)" <gi...@apache.org> on 2023/07/04 09:32:46 UTC
[GitHub] [echarts] Ovilia opened a new pull request, #18841: fix(endLabel): endLabel fail with null data #18839
Ovilia opened a new pull request, #18841:
URL: https://github.com/apache/echarts/pull/18841
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Check `setLabelText` exists before calling.
### Fixed issues
#18839
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
`endLabel` fail when data contain `null` or `'-'`.
### After: How does it behave after the fixing?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
`endLabel` not fail when data contain `null` or `'-'`.
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #18841: fix(endLabel): endLabel fail with null data #18839
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #18841:
URL: https://github.com/apache/echarts/pull/18841#issuecomment-1619927078
[View fixed case](https://echarts.apache.org/examples/zh/editor.html?version=PR-18841%4091d1e03&code=PYBwLglsB2AEC8sDeAoWtJgDYFMBcsA2musiaRjgB5gEDkO0AJgDICGARjlrAM4AWwAK5YmsaMDCwAZmwg8A7hDD9xInkzZg2dADTlSYamACCWCAHNo9AMaMjAJz0H0uabVh0ArAAYApM4U6GCgBD4GAL4kALr66FQmVBC8BMQUqEGwmtqpdDq6nhx00ZExcbAAnonJqUgRsSS8OA4QOClEBhlBYBUg-J7m0DiBQdlsqQCMBQBMDZmMrJzcBF2ZAsAKBGAOQjgusFEUEeXoq4a9_XSDwyekY6nQ6gV0ALTFt-gL7FxYK_vo602GB2e0yh1I4LmsDY0AgAFstFBoAARIQOREwAi-HzhCIAbiAA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18841: fix(endLabel): endLabel fail with null data #18839
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18841:
URL: https://github.com/apache/echarts/pull/18841#issuecomment-1619894200
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a diff in pull request #18841: fix(endLabel): endLabel fail with null data #18839
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on code in PR #18841:
URL: https://github.com/apache/echarts/pull/18841#discussion_r1251853033
##########
src/chart/line/LineView.ts:
##########
@@ -1299,7 +1299,10 @@ class LineView extends ChartView {
});
}
if (valueAnimation) {
- labelInner(endLabel).setLabelText(value);
+ const inner = labelInner(endLabel);
Review Comment:
@Ovilia How about merging this quick fix into v5.4.3 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #18841: fix(endLabel): endLabel fail with null data #18839
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia merged PR #18841:
URL: https://github.com/apache/echarts/pull/18841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18841: fix(endLabel): endLabel fail with null data #18839
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18841:
URL: https://github.com/apache/echarts/pull/18841#issuecomment-1620940358
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a diff in pull request #18841: fix(endLabel): endLabel fail with null data #18839
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on code in PR #18841:
URL: https://github.com/apache/echarts/pull/18841#discussion_r1251851819
##########
src/chart/line/LineView.ts:
##########
@@ -1299,7 +1299,10 @@ class LineView extends ChartView {
});
}
if (valueAnimation) {
- labelInner(endLabel).setLabelText(value);
+ const inner = labelInner(endLabel);
Review Comment:
The existence check for `labelInner` seems unnecessary.
https://github.com/apache/echarts/blob/master/src/util/model.ts#L736C1-L741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on pull request #18841: fix(endLabel): endLabel fail with null data #18839
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18841:
URL: https://github.com/apache/echarts/pull/18841#issuecomment-1619906870
<!-- ECHARTS_PR_PREVIEW -->
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18841@91d1e03
<!-- ECHARTS_PR_PREVIEW -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org