You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Angela Schreiber (Jira)" <ji...@apache.org> on 2020/10/01 14:16:00 UTC
[jira] [Resolved] (OAK-7919) Imporove logging for
ExternalLoginModule.java
[ https://issues.apache.org/jira/browse/OAK-7919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Angela Schreiber resolved OAK-7919.
-----------------------------------
Resolution: Resolved
IMO OAK-8102 addressed that.
> Imporove logging for ExternalLoginModule.java
> ---------------------------------------------
>
> Key: OAK-7919
> URL: https://issues.apache.org/jira/browse/OAK-7919
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Reporter: Antonio Sanso
> Priority: Minor
>
> It would be nice to improve the logging in the {{ExternalLoginModule.java}} class
> In particular IMHO it would be better to increase the log level in this snippet
> {code:java}
> } catch (LoginException e) {
> log.debug("IDP {} throws login exception for '{}': {}", idp.getName(), logId, e.getMessage());
> throw e;
> } catch (Exception e) {
> log.debug("SyncHandler {} throws sync exception for '{}'", syncHandler.getName(), logId, e);
> LoginException le = new LoginException("Error while syncing user.");
> le.initCause(e);
> throw le;
> }{code}
> See https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L254
--
This message was sent by Atlassian Jira
(v8.3.4#803005)