You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/04/10 20:42:28 UTC
svn commit: r1586402 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java

Author: mattsicker
Date: Thu Apr 10 18:42:28 2014
New Revision: 1586402

URL: http://svn.apache.org/r1586402
Log:
These methods can all be static.

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java?rev=1586402&r1=1586401&r2=1586402&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java Thu Apr 10 18:42:28 2014
@@ -898,7 +898,7 @@ public abstract class AbstractConfigurat
         return array;
     }
 
-    private String[] extractPluginAliases(final Annotation... parmTypes) {
+    private static String[] extractPluginAliases(final Annotation... parmTypes) {
         String[] aliases = null;
         for (final Annotation a : parmTypes) {
             if (a instanceof PluginAliases) {
@@ -908,7 +908,7 @@ public abstract class AbstractConfigurat
         return aliases;
     }
 
-    private <T> Object createPluginMap(final Node node, final Class<T> clazz) throws InstantiationException, IllegalAccessException {
+    private static <T> Object createPluginMap(final Node node, final Class<T> clazz) throws InstantiationException, IllegalAccessException {
         @SuppressWarnings("unchecked")
         final Map<String, Object> map = (Map<String, Object>) clazz.newInstance();
         for (final Node child : node.getChildren()) {
@@ -917,7 +917,7 @@ public abstract class AbstractConfigurat
         return map;
     }
 
-    private <T> Object createPluginCollection(final Node node, final Class<T> clazz) throws InstantiationException, IllegalAccessException {
+    private static <T> Object createPluginCollection(final Node node, final Class<T> clazz) throws InstantiationException, IllegalAccessException {
         @SuppressWarnings("unchecked")
         final Collection<Object> list = (Collection<Object>) clazz.newInstance();
         for (final Node child : node.getChildren()) {
@@ -926,7 +926,7 @@ public abstract class AbstractConfigurat
         return list;
     }
 
-    private <T> Method findFactoryMethod(final Class<T> clazz) {
+    private static <T> Method findFactoryMethod(final Class<T> clazz) {
         for (final Method method : clazz.getMethods()) {
             if (method.isAnnotationPresent(PluginFactory.class)) {
                 return method;