You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/01/14 09:36:56 UTC
[GitHub] [fineract] BLasan opened a new pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
BLasan opened a new pull request #1572:
URL: https://github.com/apache/fineract/pull/1572
## Description
Added ReadinessProbe configuration values for MySql container.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-761085385
@vorburger @xurror Could you please suggest a way to get rid of this travis build issue? I rebased the code to the latest but still getting this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-761108933
@BLasan you need to follow the process outlined on https://github.com/apache/fineract#pull-requests please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror merged pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
xurror merged pull request #1572:
URL: https://github.com/apache/fineract/pull/1572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-761141318
FINERACT-924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-766088669
@xurror without hearing back from you, I'll merge this one in 3 days. (It's obviously totally fine if you are busy, no stress; we just want to give new contributors a chance to make an impact in this project.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-762678048
@xurror please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan edited a comment on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-760297812
@xurror Travis build fails. Is this regarding to the issue[ FINERACT-887 ](https://issues.apache.org/jira/browse/FINERACT-887)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan edited a comment on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-760297812
@xurror Travis build fails. Is this due to the issue[ FINERACT-887 ](https://issues.apache.org/jira/browse/FINERACT-887)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1572: Added ReadinessProbe for mysql container (FINERACT-1292)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1572:
URL: https://github.com/apache/fineract/pull/1572#issuecomment-760297812
@xurror Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org