[jira] [Commented] (SAMZA-412) Replace usage of assert with appropriate JUnit Assert method

["Chris Riccomini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134007#comment-14134007 ] 

Chris Riccomini commented on SAMZA-412:
---------------------------------------

Thanks for doing this!

Had a look over the current patch. Didn't find anything to complain about. Let me know when you're ready, and I'll commit it.

> Replace usage of assert with appropriate JUnit Assert method
> ------------------------------------------------------------
>
>                 Key: SAMZA-412
>                 URL: https://issues.apache.org/jira/browse/SAMZA-412
>             Project: Samza
>          Issue Type: Test
>          Components: test
>            Reporter: David Chen
>            Assignee: David Chen
>              Labels: newbie
>         Attachments: SAMZA-412.0.patch
>
>
> I noticed that a number of tests use {{assert}} rather than JUnit's {{assertTrue}}, {{assertFalse}}, {{assertEquals}}, etc. methods. From looking at the [JUnit.Assert Javadoc|http://junit.sourceforge.net/javadoc/org/junit/Assert.html], it appears that we are currently just using the Scala {{assert}} rather than a JUnit method.
> We should change all uses of {{assert}} to use one of the {{JUnit.Assert}} methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)