You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/07 08:48:37 UTC
[GitHub] [flink] alpreu commented on a change in pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters
alpreu commented on a change in pull request #17819:
URL: https://github.com/apache/flink/pull/17819#discussion_r780108035
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/KerberosMountDecorator.java
##########
@@ -198,10 +199,10 @@ public FlinkPod decorateFlinkPod(FlinkPod flinkPod) {
}
public static String getKerberosKeytabSecretName(String clusterId) {
- return Constants.KERBEROS_KEYTAB_SECRET_PREFIX + clusterId;
+ return KubernetesLabel.create(clusterId, KubernetesLabel.KERBEROS_KEYTAB_SECRET_PREFIX);
}
- public static String getKerberosKrb5confConfigMapName(String clusterID) {
- return Constants.KERBEROS_KRB5CONF_CONFIG_MAP_PREFIX + clusterID;
+ public static String getKerberosKrb5confConfigMapName(String clusterId) {
+ return KubernetesLabel.create(clusterId, KubernetesLabel.KERBEROS_KEYTAB_SECRET_PREFIX);
Review comment:
Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org