You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/14 22:17:40 UTC

[GitHub] feng-tao commented on a change in pull request #3898: [AIRFLOW-3059] PostgresToGCS Log the number of rows read

feng-tao commented on a change in pull request #3898: [AIRFLOW-3059] PostgresToGCS Log the number of rows read
URL: https://github.com/apache/incubator-airflow/pull/3898#discussion_r217855498
 
 

 ##########
 File path: airflow/contrib/operators/postgres_to_gcs_operator.py
 ##########
 @@ -134,6 +134,7 @@ def _write_local_data_files(self, cursor):
         """
         schema = list(map(lambda schema_tuple: schema_tuple[0], cursor.description))
         file_no = 0
+        row_no = 1
 
 Review comment:
   maybe a dump question, but why we initialize the variable as 1 not 0? I am not very familiiar with this operator but if the  cursor doesn't return any row, the log will still print `Received 1 rows`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services