You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/02/11 22:37:36 UTC

Re: Review Request 17923: Patch for KAFKA-1243

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17923/
-----------------------------------------------------------

(Updated Feb. 11, 2014, 9:37 p.m.)


Review request for kafka.


Summary (updated)
-----------------

Patch for KAFKA-1243


Bugs: KAFKA-1243
    https://issues.apache.org/jira/browse/KAFKA-1243


Repository: kafka


Description (updated)
-------

For crross compiling with scala 2.10.*, build a single artifact with name 2.10 i(i.e., w/o minor revision) since 2.10.* are both backward and forward compatible.


1. removed "-dist" from release tgz file 2. added LICENSE and NOTICE file to all built jars 3. removed the step "./gradlew copyDependantLibs" by making it a dependency of "./gradlew core:jar"


Diffs (updated)
-----

  README.md 9b272b52c8b65668f9f2c9aa15b95b7441735936 
  build.gradle d9d6e6a91e6f37c0247107b0655f58a2db9688cd 
  scala.gradle PRE-CREATION 
  settings.gradle 74e591a8a4afc6586fd24caf7fdb3d224e126d6b 

Diff: https://reviews.apache.org/r/17923/diff/


Testing
-------


Thanks,

Jun Rao

Re: Review Request 17923: Patch for KAFKA-1243

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17923/#review34234
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Feb. 11, 2014, 9:37 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17923/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 9:37 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1243
>     https://issues.apache.org/jira/browse/KAFKA-1243
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> For crross compiling with scala 2.10.*, build a single artifact with name 2.10 i(i.e., w/o minor revision) since 2.10.* are both backward and forward compatible.
> 
> 
> 1. removed "-dist" from release tgz file 2. added LICENSE and NOTICE file to all built jars 3. removed the step "./gradlew copyDependantLibs" by making it a dependency of "./gradlew core:jar"
> 
> 
> Diffs
> -----
> 
>   README.md 9b272b52c8b65668f9f2c9aa15b95b7441735936 
>   build.gradle d9d6e6a91e6f37c0247107b0655f58a2db9688cd 
>   scala.gradle PRE-CREATION 
>   settings.gradle 74e591a8a4afc6586fd24caf7fdb3d224e126d6b 
> 
> Diff: https://reviews.apache.org/r/17923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>