[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #214: [SSHD-1257] Make ChannelOutputStream#flush no-op if the stream is already closed

[GitBox <gi...@apache.org>]

lgoldstein commented on a change in pull request #214:
URL: https://github.com/apache/mina-sshd/pull/214#discussion_r840186180



##########
File path: sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelSession.java
##########
@@ -908,7 +908,7 @@ protected void closeShell(int exitValue, boolean closeImmediately) throws IOExce
 
         if (!isClosing()) {
             if (out != null) {
-                out.flush();

Review comment:
       Not sure about this... "smells fishy" as well , though I cannot put my fiinger on it - will have to think about it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org