You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/06/03 20:02:43 UTC
Review Request: Add --enable-debug configure flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/
-----------------------------------------------------------
Review request for mesos.
Description
-------
Add --enable-debug configure flag.
Review: https://reviews.apache.org/r/11605
Diffs
-----
configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
Diff: https://reviews.apache.org/r/11605/diff/
Testing
-------
Thanks,
Brenden Matthews
Re: Review Request: Add --enable-debug configure flag.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/#review21918
-----------------------------------------------------------
Does -ggdb work with clang?
configure.ac
<https://reviews.apache.org/r/11605/#comment45216>
I think by default we want debugging symbols, so you can go ahead and add -ggdb above where we add -g. No need for an option IMO.
- Ben Mahler
On June 11, 2013, 7:31 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11605/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 7:31 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Add --enable-debug configure flag.
>
> Review: https://reviews.apache.org/r/11605
>
>
> Diffs
> -----
>
> configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
>
> Diff: https://reviews.apache.org/r/11605/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11605: Add --enable-debug configure flag.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/#review86672
-----------------------------------------------------------
Stale review: Brenden, still want this in?
- Niklas Nielsen
On June 11, 2013, 12:31 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11605/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 12:31 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Add --enable-debug configure flag.
>
> Review: https://reviews.apache.org/r/11605
>
>
> Diffs
> -----
>
> configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
>
> Diff: https://reviews.apache.org/r/11605/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Add --enable-debug configure flag.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/
-----------------------------------------------------------
(Updated June 11, 2013, 7:31 p.m.)
Review request for mesos.
Changes
-------
Rebasing on master.
Description
-------
Add --enable-debug configure flag.
Review: https://reviews.apache.org/r/11605
Diffs (updated)
-----
configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
Diff: https://reviews.apache.org/r/11605/diff/
Testing (updated)
-------
Used in production at airbnb.
make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
Thanks,
Brenden Matthews
Re: Review Request: Add --enable-debug configure flag.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/
-----------------------------------------------------------
(Updated June 6, 2013, 2:08 a.m.)
Review request for mesos.
Changes
-------
Rebasing on master.
Description
-------
Add --enable-debug configure flag.
Review: https://reviews.apache.org/r/11605
Diffs (updated)
-----
configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
Diff: https://reviews.apache.org/r/11605/diff/
Testing
-------
Thanks,
Brenden Matthews
Re: Review Request: Add --enable-debug configure flag.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On June 3, 2013, 8:25 p.m., Charles Reiss wrote:
> > configure.ac, line 429
> > <https://reviews.apache.org/r/11605/diff/1/?file=300052#file300052line429>
> >
> > Suggest just '-g' to avoid assuming too much about the compiler.
Good point.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/#review21349
-----------------------------------------------------------
On June 3, 2013, 6:02 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11605/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 6:02 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Add --enable-debug configure flag.
>
> Review: https://reviews.apache.org/r/11605
>
>
> Diffs
> -----
>
> configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
>
> Diff: https://reviews.apache.org/r/11605/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Add --enable-debug configure flag.
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/#review21349
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/11605/#comment44255>
Suggest just '-g' to avoid assuming too much about the compiler.
- Charles Reiss
On June 3, 2013, 6:02 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11605/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 6:02 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Add --enable-debug configure flag.
>
> Review: https://reviews.apache.org/r/11605
>
>
> Diffs
> -----
>
> configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
>
> Diff: https://reviews.apache.org/r/11605/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Add --enable-debug configure flag.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11605/#review21397
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/11605/#comment44326>
This bit ensures -g is present, no?
- Ben Mahler
On June 3, 2013, 6:02 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11605/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 6:02 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Add --enable-debug configure flag.
>
> Review: https://reviews.apache.org/r/11605
>
>
> Diffs
> -----
>
> configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e
>
> Diff: https://reviews.apache.org/r/11605/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brenden Matthews
>
>