You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/10 12:18:15 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #3822: Add segment v2 footer meta viewer
yangzhg opened a new pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822
Add segment v2 footer meta viewer tool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3822: Add segment v2 footer meta viewer
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822#discussion_r438237646
##########
File path: be/src/tools/meta_tool.cpp
##########
@@ -34,6 +34,13 @@
#include "json2pb/pb_to_json.h"
#include "gutil/strings/split.h"
#include "gutil/strings/numbers.h"
+#include "gutil/strings/substitute.h"
+#include "util/coding.h"
+#include "util/crc32c.h"
+#include "olap/rowset/segment_v2/column_reader.h"
+#include "olap/rowset/segment_v2/binary_plain_page.h"
+#include "gen_cpp/segment_v2.pb.h"
+#include "env/env.h"
Review comment:
place the include file in alphabetical order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3822: Add segment v2 footer meta viewer
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822#discussion_r440573216
##########
File path: be/src/tools/meta_tool.cpp
##########
@@ -34,6 +34,13 @@
#include "json2pb/pb_to_json.h"
#include "gutil/strings/split.h"
#include "gutil/strings/numbers.h"
+#include "gutil/strings/substitute.h"
+#include "util/coding.h"
+#include "util/crc32c.h"
+#include "olap/rowset/segment_v2/column_reader.h"
+#include "olap/rowset/segment_v2/binary_plain_page.h"
+#include "gen_cpp/segment_v2.pb.h"
+#include "env/env.h"
Review comment:
@chaoyli please review again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3822: Add segment v2 footer meta viewer
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822#discussion_r441983032
##########
File path: docs/en/administrator-guide/operation/tablet-meta-tool.md
##########
@@ -130,8 +130,18 @@ Batch delete will skip the line with incorrect tablet information format in `tab
This command is to view the old file-based management PB format Tablet Meta, and to display Tablet Meta in JSON format.
-Order:
+Command:
```
-./lib/meta_tool --operation=show_meta --root_path=/path/to/root_path --pb_header_path=path
+./lib/meta_tool --operation=how_meta --root_path=/path/to/root_path --pb_header_path=path
Review comment:
```suggestion
./lib/meta_tool --operation=show_meta --root_path=/path/to/root_path --pb_header_path=path
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3822: Add segment v2 footer meta viewer
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822#discussion_r440596514
##########
File path: docs/zh-CN/administrator-guide/operation/tablet-meta-tool.md
##########
@@ -136,4 +136,13 @@ api：
./lib/meta_tool --operation=show_meta --root_path=/path/to/root_path --pb_header_path=path
```
+### 展示 pb 格式的 Segment Footer
+
+这个命令是为了查看SegmentV2 的SegmentFooterPB信息，以json 形式展示出来
Review comment:
Would better show the command result by a simple example. Because most of people don't know what's SegmentFooterPB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3822: Add segment v2 footer meta viewer
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org