You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/03 08:53:57 UTC
[GitHub] [shardingsphere] taojintianxia opened a new pull request #7236: Refactor: overload the scaling MetaDataManager
taojintianxia opened a new pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236
Changes proposed in this pull request:
- overload the getTableMetaData because `TableMetaDataLoader.load` accept databaseType , then hard code an empty string is not a good way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7236: Refactor: overload the scaling MetaDataManager
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236#issuecomment-686398456
## Pull Request Test Coverage Report for [Build 14391](https://coveralls.io/builds/33203457)
* **4** of **4** **(100.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.001%**) to **34.1%**
---
| Totals | [](https://coveralls.io/builds/33203457) |
| :-- | --: |
| Change from base [Build 14390](https://coveralls.io/builds/33202807): | 0.001% |
| Covered Lines: | 35412 |
| Relevant Lines: | 103848 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia closed pull request #7236: Refactor: overload the scaling MetaDataManager
Posted by GitBox <gi...@apache.org>.
taojintianxia closed pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Lucas-307 commented on a change in pull request #7236: Refactor: overload the scaling MetaDataManager
Posted by GitBox <gi...@apache.org>.
Lucas-307 commented on a change in pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236#discussion_r482861272
##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/metadata/MetaDataManager.java
##########
@@ -43,9 +43,20 @@
* @return table meta data
*/
public TableMetaData getTableMetaData(final String tableName) {
+ return getTableMetaData(tableName, "");
Review comment:
Hi, if you add `getTableMetaData(final String tableName, final String databaseType)` function. This function do not have to exist. and you should update all quote.
How do you know which function can use in which case?
And `databaseType` only affect `Oracle` database, but we don't support `Oracle` in scaling.
So, I suggest keep current code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #7236: Refactor: overload the scaling MetaDataManager
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236#discussion_r482864400
##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/metadata/MetaDataManager.java
##########
@@ -43,9 +43,20 @@
* @return table meta data
*/
public TableMetaData getTableMetaData(final String tableName) {
+ return getTableMetaData(tableName, "");
Review comment:
I understand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #7236: Refactor: overload the scaling MetaDataManager
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236#discussion_r482866605
##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/metadata/MetaDataManager.java
##########
@@ -43,9 +43,20 @@
* @return table meta data
*/
public TableMetaData getTableMetaData(final String tableName) {
+ return getTableMetaData(tableName, "");
Review comment:
my origin though is replace `getTableMetaData(final String tableName) ` with `getTableMetaData(final String tableName, final String databaseType) ` one by one , and drop `getTableMetaData(final String tableName) ` at last . since we don't support Oracle . enn , I see
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org