[GitHub] [druid] maytasm commented on a change in pull request #9778: Fix problem when running single integration test using -Dit.test=

[GitBox <gi...@apache.org>]

maytasm commented on a change in pull request #9778:
URL: https://github.com/apache/druid/pull/9778#discussion_r416943418



##########
File path: integration-tests/src/main/java/org/testng/DruidTestRunnerFactory.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package /*CHECKSTYLE.OFF: PackageName*/org.testng/*CHECKSTYLE.ON: PackageName*/;
+
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.testing.utils.SuiteListener;
+import org.testng.internal.IConfiguration;
+import org.testng.internal.Systematiser;
+import org.testng.internal.annotations.IAnnotationFinder;
+import org.testng.xml.XmlTest;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * This class must be in package org.testng to access protected methods like TestNG.getDefault().getConfiguration()
+ */
+public class DruidTestRunnerFactory implements ITestRunnerFactory
+{
+  private static final Logger LOG = new Logger(DruidTestRunnerFactory.class);
+  private static final SuiteListener SUITE_LISTENER = new SuiteListener();
+
+  @Override
+  public TestRunner newTestRunner(ISuite suite,
+                                  XmlTest test,
+                                  Collection<IInvokedMethodListener> methodListeners,
+                                  List<IClassListener> classListeners)
+  {
+    IConfiguration configuration = TestNG.getDefault().getConfiguration();
+    String outputDirectory = suite.getOutputDirectory();
+    IAnnotationFinder annotationFinder = configuration.getAnnotationFinder();
+    Boolean skipFailedInvocationCounts = suite.getXmlSuite().skipFailedInvocationCounts();
+    return new DruidTestRunner(
+        configuration,
+        suite,
+        test,
+        outputDirectory,
+        annotationFinder,
+        skipFailedInvocationCounts,
+        methodListeners,
+        classListeners
+    );
+  }
+
+  private static class DruidTestRunner extends TestRunner
+  {
+    DruidTestRunner(
+        IConfiguration configuration,
+        ISuite suite,
+        XmlTest test,
+        String outputDirectory,
+        IAnnotationFinder finder,
+        boolean skipFailedInvocationCounts,
+        Collection<IInvokedMethodListener> methodListeners,
+        List<IClassListener> classListeners
+    )
+    {
+      super(configuration, suite, test, outputDirectory, finder, skipFailedInvocationCounts, methodListeners, classListeners, Systematiser.getComparator(), Collections.emptyMap());
+    }
+
+    @Override
+    public void run()
+    {
+      try {
+        // IntegrationTestSuite is run when -Dit.test is not specify in maven command.
+        // IntegrationTestSuite uses the configuration from integration-tests/src/test/resources/testng.xml
+        // which already handle suite onStart and onFinish automatically
+        if (!"IntegrationTestSuite".equals(getSuite().getName())) {
+          SUITE_LISTENER.onStart(getSuite());
+        }
+        runTests();
+      }
+      catch (Exception e) {
+        LOG.error(e, "");

Review comment:
       Removed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org