[jira] [Commented] (MAHOUT-1882) SequentialAccessSparseVector inerateNonZeros is incorrect.

["Pat Ferrel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812561#comment-15812561 ] 

Pat Ferrel commented on MAHOUT-1882:
------------------------------------

Can't see that I use this, at least not obviously unless it is hidden in another call. Can you try removing the method and see who complains?

> SequentialAccessSparseVector inerateNonZeros is incorrect.
> ----------------------------------------------------------
>
>                 Key: MAHOUT-1882
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1882
>             Project: Mahout
>          Issue Type: Bug
>          Components: Math
>    Affects Versions: 0.12.2
>            Reporter: Andrew Palumbo
>            Assignee: Suneel Marthi
>            Priority: Critical
>             Fix For: 0.13.0
>
>
> In {{SequentialAccessSparseVector}} a bug is noted.  When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
> {code}
>  @Override
>   public Iterator<Element> iterateNonZero() {
>     // TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
>     return new NonDefaultIterator();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)