Re: [PATCH] Release candidate patch for adding external lockingfilecode to svn_repos_open

[Files <fi...@poetryunlimited.com>]

David,

If the lock_time can't be in the repos_t, something else needs to be.

The real behavior that we're presenting is that the system only attempt to
lock once per repository.

Since you had originally had the lock_time set to 0 and then set it to a value
later, I used that.

It doesn't need to be lock_time. But there needs to be a sentinel. Otherwise,
you retry the lock each time.

I'm looking to try the lock only once. A singleton operation. per instance of
the repository.

It's a per-repository lock, so if there is more than one repository being
accessed via svn:externals or what not, you run into issues.

It's also a per-repository option.

What is the behavior when you have the lock_time located in the repos_t???

Am I making any sense?

Thanks.
-- 
Shamim Islam
BA BS

David Kopp said:
> Hello again,
>
> I have made a few modifications to Shamim's patch and come up with the
> attached patch.
>
> I moved some of the functions to the top of the file in order to satisfy
> the compiler. I also removed lock_time from svn_repos_t and made it a
> static variable of create_external_lock_if_requested. (It doesn't work
> otherwise).
>
> So, what do the rest of you think? I would like to have this added,
> because then I would be able to use Subversion at work.
>
> David Kopp
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org