[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3331: HIVE-26266: Column information is not present in lineage for CTAS whe…

[GitBox <gi...@apache.org>]

kgyrtkirk commented on code in PR #3331:
URL: https://github.com/apache/hive/pull/3331#discussion_r885344481


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -8232,6 +8232,14 @@ private void handleLineage(LoadTableDesc ltd, Operator output)
         Warehouse wh = new Warehouse(conf);
         tlocation = wh.getDefaultTablePath(db.getDatabase(tableDesc.getDatabaseName()),
             tName, tableDesc.isExternal());
+
+        if (destinationTable != null) {
+          Table tbl = db.getTranslateTableDryrun(destinationTable.getTTable());

Review Comment:
   isn't it a bit too late to run this? why don't we run this right away when we are creating the `destinationTable` object?
   so that we don't make the same mistake again-and-again?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org