You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/07/11 13:05:18 UTC
[GitHub] [avro] martin-g commented on a diff in pull request #1759: AVRO-3573: Duplicate symbols (EnumSchema)
martin-g commented on code in PR #1759:
URL: https://github.com/apache/avro/pull/1759#discussion_r917905621
##########
lang/py/avro/test/test_schema.py:
##########
@@ -713,6 +713,20 @@ def test_parse_invalid_symbol(self):
except avro.errors.InvalidName: # pragma: no coverage
self.fail("When enum symbol validation is disabled, an invalid symbol should not raise InvalidName.")
+ def test_parse_duplicate_symbol(self):
+ duplicate_symbol_schema = json.dumps({"type": "enum", "name": "AVRO3573", "symbols": ["A", "A", "B", "C", "D"]})
+ with self.assertRaisesRegex(
+ avro.errors.AvroException, r"Duplicate symbol: \[\'A\'\]", msg="When enum symbol has a duplicate, AvroException should raise."
Review Comment:
It seems the escaping is not needed here
##########
lang/py/avro/test/test_schema.py:
##########
@@ -713,6 +713,20 @@ def test_parse_invalid_symbol(self):
except avro.errors.InvalidName: # pragma: no coverage
self.fail("When enum symbol validation is disabled, an invalid symbol should not raise InvalidName.")
+ def test_parse_duplicate_symbol(self):
+ duplicate_symbol_schema = json.dumps({"type": "enum", "name": "AVRO3573", "symbols": ["A", "A", "B", "C", "D"]})
+ with self.assertRaisesRegex(
+ avro.errors.AvroException, r"Duplicate symbol: \[\'A\'\]", msg="When enum symbol has a duplicate, AvroException should raise."
+ ):
+ avro.schema.parse(duplicate_symbol_schema)
+
+ def test_parse_duplicate_symbols(self):
+ duplicate_symbols_schema = json.dumps({"type": "enum", "name": "AVRO3573", "symbols": ["A", "A", "B", "C", "C", "D"]})
+ with self.assertRaisesRegex(
+ avro.errors.AvroException, r"Duplicate symbols: \[\'A\', \'C\'\]", msg="When enum symbols have duplicates, AvroException should raise."
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org