You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 10:46:06 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #13117: Update compatibility with google-cloud-redis==2.0.0

potiuk commented on a change in pull request #13117:
URL: https://github.com/apache/airflow/pull/13117#discussion_r545750424



##########
File path: airflow/providers/google/cloud/example_dags/example_cloud_memorystore.py
##########
@@ -161,7 +161,7 @@
     set_acl_permission = GCSBucketCreateAclEntryOperator(
         task_id="gcs-set-acl-permission",
         bucket=BUCKET_NAME,
-        entity="user-{{ task_instance.xcom_pull('get-instance')['persistenceIamIdentity']"
+        entity="user-{{ task_instance.xcom_pull('get-instance')['persistence_iam_identity']"

Review comment:
       CAan we keep backwards-compatibility? I think we should change our approach and only introduce backwards-incompatible changes in providers if we absolutely must and there is no other way to solve it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org