You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 14:00:06 UTC

[GitHub] [phoenix-connectors] stoty commented on a change in pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty commented on a change in pull request #44:
URL: https://github.com/apache/phoenix-connectors/pull/44#discussion_r540190367



##########
File path: phoenix-kafka-base/pom.xml
##########
@@ -26,8 +26,9 @@
   <modelVersion>4.0.0</modelVersion>
   <parent>
     <groupId>org.apache.phoenix</groupId>
-    <artifactId>phoenix-connectors</artifactId>
+    <artifactId>phoenix-connectors-base</artifactId>
     <version>6.0.0-SNAPSHOT</version>
+    <relativePath>../phoenix-connectors-base/pom.xml</relativePath>

Review comment:
       I'd prefer that we relocate the directories to to follow the maven structure, instead of hacking it around like this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org