You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mh...@apache.org on 2018/08/09 22:15:05 UTC
asterixdb git commit: [NO ISSUE][OTH] Log Level Fixes
Repository: asterixdb
Updated Branches:
refs/heads/master 808b2cec7 -> 4f26f9ab5
[NO ISSUE][OTH] Log Level Fixes
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2865
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Michael Blow <mb...@apache.org>
Tested-by: Michael Blow <mb...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/4f26f9ab
Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/4f26f9ab
Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/4f26f9ab
Branch: refs/heads/master
Commit: 4f26f9ab5a1b447ab7926a626b22207ef0bb44e8
Parents: 808b2ce
Author: Murtadha Hubail <mh...@apache.org>
Authored: Thu Aug 9 14:13:26 2018 -0700
Committer: Murtadha Hubail <mh...@apache.org>
Committed: Thu Aug 9 15:14:46 2018 -0700
----------------------------------------------------------------------
.../hyracks/control/nc/heartbeat/HeartbeatComputeTask.java | 2 +-
.../apache/hyracks/control/nc/heartbeat/HeartbeatTask.java | 2 +-
.../hyracks/dataflow/std/sort/AbstractFrameSorter.java | 4 ++--
.../storage/am/lsm/common/impls/VirtualBufferCache.java | 9 ++++-----
4 files changed, 8 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/4f26f9ab/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
----------------------------------------------------------------------
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
index 9bfd061..81ceea5 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
@@ -103,6 +103,6 @@ public class HeartbeatComputeTask extends TimerTask {
ncs.getNodeControllerData().notifyHeartbeat(hbData);
}
- LOGGER.log(Level.DEBUG, "Successfully refreshed heartbeat data");
+ LOGGER.trace("Successfully refreshed heartbeat data");
}
}
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/4f26f9ab/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
----------------------------------------------------------------------
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
index 9160e46..6d08fb1 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
@@ -69,7 +69,7 @@ public class HeartbeatTask implements Runnable {
synchronized (hbData) {
cc.nodeHeartbeat(ncId, hbData);
}
- LOGGER.log(Level.DEBUG, "Successfully sent heartbeat");
+ LOGGER.trace("Successfully sent heartbeat");
return true;
} catch (InterruptedException e) {
throw e;
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/4f26f9ab/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
----------------------------------------------------------------------
diff --git a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
index f51271e..980ad9b 100644
--- a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
+++ b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
@@ -235,8 +235,8 @@ public abstract class AbstractFrameSorter implements IFrameSorter {
}
maxFrameSize = Math.max(maxFrameSize, outputFrame.getFrameSize());
outputAppender.write(writer, true);
- if (LOGGER.isDebugEnabled()) {
- LOGGER.debug(
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace(
"Flushed records:" + limit + " out of " + tupleCount + "; Flushed through " + (io + 1) + " frames");
}
return maxFrameSize;
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/4f26f9ab/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
----------------------------------------------------------------------
diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
index e63a5b8..0a7c842 100644
--- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
+++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
@@ -40,7 +40,6 @@ import org.apache.hyracks.storage.common.file.BufferedFileHandle;
import org.apache.hyracks.storage.common.file.FileMapManager;
import org.apache.hyracks.storage.common.file.IFileMapManager;
import org.apache.hyracks.util.JSONUtil;
-import org.apache.logging.log4j.Level;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -126,8 +125,8 @@ public class VirtualBufferCache implements IVirtualBufferCache {
}
private void logStats() {
- if (LOGGER.isInfoEnabled()) {
- LOGGER.log(Level.INFO, "Free (allocated) pages = " + freePages.size() + ". Budget = " + pageBudget
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace("Free (allocated) pages = " + freePages.size() + ". Budget = " + pageBudget
+ ". Large pages = " + largePages.get() + ". Overall usage = " + used.get());
}
}
@@ -188,8 +187,8 @@ public class VirtualBufferCache implements IVirtualBufferCache {
bucket.bucketLock.unlock();
}
}
- if (LOGGER.isInfoEnabled()) {
- LOGGER.log(Level.INFO, "Reclaimed pages = " + reclaimedPages);
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace("Reclaimed pages = " + reclaimedPages);
}
logStats();
}