You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by myui <gi...@git.apache.org> on 2017/12/27 07:23:30 UTC

[GitHub] incubator-hivemall pull request #129: [HIVEMALL-164] Fixed pom for appending...

GitHub user myui opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/129

    [HIVEMALL-164] Fixed pom for appending proper NOTICE/LICENSE/DISCLAIMER to jars

    ## What changes were proposed in this pull request?
    
    Fixed pom for appending proper NOTICE/LICENSE/DISCLAIMER to jars. `maven-remote-resources-plugin` used in parent Apache pom does not work well.
    
    This PR closes #128
    
    ## What type of PR is it?
    
    Improvement
    
    ## What is the Jira issue?
    
    https://issues.apache.org/jira/browse/HIVEMALL-164
    
    ## How was this patch tested?
    
    manual tests
    
    ## How to use this feature?
    
    `./bin/build.sh`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/myui/incubator-hivemall HIVEMALL-164

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit c9e73b64566337b8b14973463fa5097888ce18d3
Author: Makoto Yui <my...@...>
Date:   2017-12-27T07:18:49Z

    Fixed pom for appending proper NOTICE/LICENSE/DISCLAIMER to jars

----


---

[GitHub] incubator-hivemall issue #129: [HIVEMALL-164] Fixed pom for appending proper...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/129
  
    
    [![Coverage Status](https://coveralls.io/builds/14811675/badge)](https://coveralls.io/builds/14811675)
    
    Coverage decreased (-0.008%) to 42.086% when pulling **c9e73b64566337b8b14973463fa5097888ce18d3 on myui:HIVEMALL-164** into **7ecc8df71e77240845d0f1a38c6ce2b838d62259 on apache:master**.



---

[GitHub] incubator-hivemall pull request #129: [HIVEMALL-164] Fixed pom for appending...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hivemall/pull/129


---