You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/07/28 03:46:06 UTC
[PR] [WIP][ML] Include LDA metadata in size estimates [spark]
zhengruifeng opened a new pull request, #57589:
URL: https://github.com/apache/spark/pull/57589
### What changes were proposed in this pull request?
Adds parameter metadata to `DistributedLDAModel.estimatedSize` while retaining its existing Arrow-data estimates for the serialized LDA internals. Adds regression coverage using a small EM LDA model.
### Why are the changes needed?
The specialized estimate counted distributed model data but omitted the model's parameter metadata.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added `DistributedLDAModel estimated size` coverage in `LDASuite`. The suite was not run locally.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58395][ML][CONNECT] Include LDA metadata in size estimates [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #57589:
URL: https://github.com/apache/spark/pull/57589#issuecomment-5164053310
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/7864cd1c50bb776788459d241b437c10bf11fa25
- merged into branch-4.x https://github.com/apache/spark/commit/44c4f0e1c7a3532103cb7dc5741152aca3f07146
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58395][ML][CONNECT] Include LDA metadata in size estimates [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #57589: [SPARK-58395][ML][CONNECT] Include LDA metadata in size estimates
URL: https://github.com/apache/spark/pull/57589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org