Re: [PR] IGNITE-23693: Sql. After canceling a long-running DML query, the implicit tx is not rolled back. [ignite-3]

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #4838:
URL: https://github.com/apache/ignite-3/pull/4838#discussion_r1873273402


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -336,13 +336,19 @@ private CompletableFuture<AsyncDataCursor<InternalSqlRow>> executeQuery(
 
         CompletableFuture<Void> firstPageReady0 = firstPageReady;
 
-        Predicate<String> nodeExclusionFilter = operationContext.nodeExclusionFilter(); 
+        Predicate<String> nodeExclusionFilter = operationContext.nodeExclusionFilter();
 
-        return queryManager.execute(tx, plan, nodeExclusionFilter).thenApply(dataCursor -> new TxAwareAsyncCursor<>(
+        CompletableFuture<AsyncDataCursor<InternalSqlRow>> f = queryManager.execute(tx, plan,

Review Comment:
   let's add the test to `ExecutionServiceImplTest` which covers this particular case (you need to make sure that transaction is rolled back if distributed query were unable to initialize)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org