You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "Feggah (via GitHub)" <gi...@apache.org> on 2023/05/24 18:28:48 UTC
[GitHub] [incubator-devlake] Feggah opened a new issue, #5279: [Feature][PagerDuty] Support specifying Custom Rate Limit with requests/min instead of requests/hour
Feggah opened a new issue, #5279:
URL: https://github.com/apache/incubator-devlake/issues/5279
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar feature requirement.
### Use case
Based on the [PagerDuty documentation](https://developer.pagerduty.com/docs/ZG9jOjExMDI5NTUz-rate-limiting) and the [PagerDuty community forum](https://community.pagerduty.com/forum/t/which-rate-limit-of-rest-api-is-correct/3322) the Rate Limit for PagerDuty is 900 requests/min.
We should be able to specify Custom Rate Limit with requests/min instead of requests/hour for PagerDuty.
Also, the message `PagerDuty does not specify a maximum value of rate limit.` should be changed to `PagerDuty specifies a maximum value of 900 requests/min for rate limit.`
### Description
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Feggah commented on issue #5279: [Feature][PagerDuty] Support specifying Custom Rate Limit with requests/min instead of requests/hour
Posted by "Feggah (via GitHub)" <gi...@apache.org>.
Feggah commented on issue #5279:
URL: https://github.com/apache/incubator-devlake/issues/5279#issuecomment-1564697003
Awesome, I'll close this issue then. Thanks for the clarification!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Feggah closed issue #5279: [Feature][PagerDuty] Support specifying Custom Rate Limit with requests/min instead of requests/hour
Posted by "Feggah (via GitHub)" <gi...@apache.org>.
Feggah closed issue #5279: [Feature][PagerDuty] Support specifying Custom Rate Limit with requests/min instead of requests/hour
URL: https://github.com/apache/incubator-devlake/issues/5279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #5279: [Feature][PagerDuty] Support specifying Custom Rate Limit with requests/min instead of requests/hour
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #5279:
URL: https://github.com/apache/incubator-devlake/issues/5279#issuecomment-1562230412
Thanks for the suggestion, however, I think we should keep it simple by converting Requests per Minute to Requests per Hour.
It would be 54000 Requests Per Hours in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Feggah commented on issue #5279: [Feature][PagerDuty] Support specifying Custom Rate Limit with requests/min instead of requests/hour
Posted by "Feggah (via GitHub)" <gi...@apache.org>.
Feggah commented on issue #5279:
URL: https://github.com/apache/incubator-devlake/issues/5279#issuecomment-1562478941
My only concern here is how this requests/hour are distributed? Because 54000 requested/hour isn't necessarily the same as 900 requests/min.
For example, if I specify 54000 requests/hour, the code distributes it evenly throughout the whole hour (thus, using 900/min) or it tries to go as fast as possible and could, for example, do this 54000 requests in 10 minutes (then waiting 50minutes idle to request again)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #5279: [Feature][PagerDuty] Support specifying Custom Rate Limit with requests/min instead of requests/hour
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #5279:
URL: https://github.com/apache/incubator-devlake/issues/5279#issuecomment-1563867143
@Feggah Good question, it is evenly distributed. So, 900 rpm and 54000 rph are equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org