You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yixiutt (via GitHub)" <gi...@apache.org> on 2023/02/22 08:09:01 UTC

[GitHub] [doris] yixiutt commented on a diff in pull request #17004: [Fix](load)Pass hidden column to load columns.

yixiutt commented on code in PR #17004:
URL: https://github.com/apache/doris/pull/17004#discussion_r1113964073


##########
fe/fe-core/src/main/java/org/apache/doris/load/Load.java:
##########
@@ -610,9 +610,9 @@ private static void initColumns(Table tbl, List<ImportColumnDesc> columnExprs,
             if (hiddenColumns != null) {
                 for (String columnName : hiddenColumns) {
                     Column column = tbl.getColumn(columnName);
-                    if (column != null && !column.isVisible()) {
-                        ImportColumnDesc columnDesc = new ImportColumnDesc(column.getName());
-                        LOG.debug("add hidden column {} to stream load task", column.getName());
+                    if (column == null || !column.isVisible()) {

Review Comment:
   may add sequence column twice?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org