You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/19 15:08:42 UTC

[GitHub] [netbeans] JaroslavTulach opened a new pull request #3118: By default build release-like version of .vsix

JaroslavTulach opened a new pull request #3118:
URL: https://github.com/apache/netbeans/pull/3118


   The `.vsix` file as published on [marketplace](https://marketplace.visualstudio.com/items?itemName=ASF.apache-netbeans-java) has traditionally been assembled together with `nbjavac` library for better cross-JDK editing support and ability to run the extension on JDK8 without any additional downloads. Time to make it the default. That's what  1d74cad does.
   
   In addition to that I am opening access to default release catalog - originally removed in a panic by ac183a7904d1c53d7e89df18e36bcc8188005b19 - turned out that properly building the `.vsix` file with proper metarelease information and also fa85b5178041cba0ab65d70ec2e6a6340a04ef5e is enough to prevent the former problems.
   
   Moreover having the update center enabled allows one to install additional modules not packaged in `.vsix` by default:
   ```bash
   java/java.lsp.server/vscode$ npm run nbcode -- --modules --install .*debugger.*
   
   > apache-netbeans-java@12.4.0 nbcode /home/devel/NetBeansProjects/netbeans2/java/java.lsp.server/vscode
   > node ./out/nbcode.js "--modules" "--install" ".*debugger.*"
   
   Installing org.netbeans.modules.debugger.jpda.ant@1.51
   
   Installing org.netbeans.modules.debugger.jpda.heapwalk@1.44
   Installing org.netbeans.modules.debugger.jpda.visual@1.30
   Installing org.netbeans.modules.web.javascript.debugger@1.28
   Installing org.netbeans.modules.ant.debugger@1.50.0.2
   Installing org.netbeans.modules.debugger.jpda.jsui@1.13
   Installing org.netbeans.modules.debugger.jpda.js@1.23
   Installing org.netbeans.modules.debugger.jpda.kit@1.28
   
   modules=21
   
   Establishing a connection ...
   Establishing a connection ...
   ```
   which greatly enhances the flexibility of our VSCode support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] JaroslavTulach edited a comment on pull request #3118: By default build release-like version of .vsix

Posted by GitBox <gi...@apache.org>.
JaroslavTulach edited a comment on pull request #3118:
URL: https://github.com/apache/netbeans/pull/3118#issuecomment-905165868


   > That's nice.
   > ... anyone could write a VSCode extension that would install some NB modules to extend the VSCode functionality.
   
   Yes, this was always the goal! Anyone can write a VSCode extension and extend the functionality. To quote #2570:
   
   > The launcher attempts to support extensibility. nbcode.ts scans all activated extensions and collects clusters from nbcode subdirectory. As such it is possible for various VSCode extensions to contribute modules into the same backend and enhance its functionality.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] JaroslavTulach merged pull request #3118: By default build release-like version of .vsix

Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #3118:
URL: https://github.com/apache/netbeans/pull/3118


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] JaroslavTulach commented on pull request #3118: By default build release-like version of .vsix

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3118:
URL: https://github.com/apache/netbeans/pull/3118#issuecomment-905164474


   > Now we're past legal questions on nb-javac, be good to move to bundling by default with the IDE too for 12.6. Which might later lead to revising this?
   
   Hopefully the operation is idempotent: if the nb-javac modules are already in, nothing happens. Of course, if the catalog isn't produced during the build, this piece of Ant script has to be deleted as well.
   
   > One question for both would be - what's the mechanism for disabling nb-javac when bundled, possibly for testing, but also when release target is higher (eg. 17-EA) than supported by nb-javac?
   
   I usually use
   
   ```bash
   $ find netbeans | grep nbjavac | xargs rm
   ```
   but I agree, it is not very end-user friendly. If nb-javac is visible in "Tools/Plugins", users of NetBeans IDE could potentially disable it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] entlicher commented on pull request #3118: By default build release-like version of .vsix

Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #3118:
URL: https://github.com/apache/netbeans/pull/3118#issuecomment-902085703


   That's nice.
   Installation of additional modules is nice for power users, the corresponding functionality might be limited by the existing LSP support. But if LSP is made extensible via NB modules, anyone could write a VSCode extension that would install some NB modules to extend the VSCode functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] JaroslavTulach commented on pull request #3118: By default build release-like version of .vsix

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3118:
URL: https://github.com/apache/netbeans/pull/3118#issuecomment-905165868


   > That's nice.
   > ... anyone could write a VSCode extension that would install some NB modules to extend the VSCode functionality.
   
   Yes, this was always the goal! Anyone can write a VSCode extension and extend the functionality. To quote #2570 
   
   > The launcher attempts to support extensibility. nbcode.ts scans all activated extensions and collects clusters from nbcode subdirectory. As such it is possible for various VSCode extensions to contribute modules into the same backend and enhance its functionality.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists