You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/26 13:01:56 UTC
[GitHub] [cloudstack] sureshanaparti opened a new pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
sureshanaparti opened a new pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377
### Description
Worker VM tags are missed for few cloned VMs in VMware, and so these are skipped when tracking / cleaning up of Worker VMs. Adding proper Worker VM tags to these VMs would make them trackable from CloudStack.
This PR updates the (missed) Worker VM tags for the cloned VMs (in VMware) when creating template from volume, and exporting volume to secondary storage.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Snapshot operation (for detached disk) tasks in vCenter =>
<img width="1264" alt="01_SnapshotOperation" src="https://user-images.githubusercontent.com/12028987/130967118-3f135bce-b077-41b6-9b01-2fa787a3e29d.png">
Worker VM to attach disk =>
<img width="863" alt="02_WorkerVMToAttachDisk" src="https://user-images.githubusercontent.com/12028987/130967146-f85fd9c5-c49b-4a5a-96af-ddd388f61319.png">
Cloned VM to export disk to secondary storage =>
<img width="870" alt="03_ClonedVMToExportDisk" src="https://user-images.githubusercontent.com/12028987/130967165-79e865e8-67fd-48fa-9776-bb998f9f5abb.png">
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Manually verified the worker VM tags set in the cloned VMs (from vCenter) while performing the following operations.
- Take volume snapshot
- Create template from volume
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908049920
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908072032
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908036267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-906395013
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-906421257
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-906395672
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-907117246
@sureshanaparti does this affect 4.15? If so please change PR branch to 4.15 esp for bugfixes, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908062134
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908036267
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908036160
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-906416580
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908036160
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908048598
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian. SL-JID 1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908558883
<b>Trillian test result (tid-1836)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39415 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5377-t1836-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-906823517
<b>Trillian test result (tid-1781)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36593 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5377-t1781-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908558883
<b>Trillian test result (tid-1836)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39415 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5377-t1836-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908050065
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-906420353
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5377:
URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-908072377
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org