You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jay Kreps <bo...@gmail.com> on 2014/04/02 19:21:08 UTC
Review Request 19947: Patch for KAFKA-1327
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19947/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1327
https://issues.apache.org/jira/browse/KAFKA-1327
Repository: kafka
Description
-------
KAFKA-1327 Add log cleaner metrics.
Diffs
-----
core/src/main/scala/kafka/log/Log.scala b3ab5220a66a2ae82084dad89877daf60f613e66
core/src/main/scala/kafka/log/LogCleaner.scala 312204c6ddd0cf46cd7349d79a43edec839bc361
core/src/main/scala/kafka/log/LogCleanerManager.scala 43e5c1fd6d9d99f6a47af2136a3d15b9799d4947
core/src/main/scala/kafka/utils/Throttler.scala c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8
Diff: https://reviews.apache.org/r/19947/diff/
Testing
-------
Thanks,
Jay Kreps
Re: Review Request 19947: Patch for KAFKA-1327
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19947/#review39537
-----------------------------------------------------------
Ship it!
Ship It!
- Jun Rao
On April 2, 2014, 5:21 p.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19947/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 5:21 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1327
> https://issues.apache.org/jira/browse/KAFKA-1327
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1327 Add log cleaner metrics.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala b3ab5220a66a2ae82084dad89877daf60f613e66
> core/src/main/scala/kafka/log/LogCleaner.scala 312204c6ddd0cf46cd7349d79a43edec839bc361
> core/src/main/scala/kafka/log/LogCleanerManager.scala 43e5c1fd6d9d99f6a47af2136a3d15b9799d4947
> core/src/main/scala/kafka/utils/Throttler.scala c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8
>
> Diff: https://reviews.apache.org/r/19947/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>
Re: Review Request 19947: Patch for KAFKA-1327
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19947/#review39543
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 2, 2014, 5:21 p.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19947/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 5:21 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1327
> https://issues.apache.org/jira/browse/KAFKA-1327
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1327 Add log cleaner metrics.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala b3ab5220a66a2ae82084dad89877daf60f613e66
> core/src/main/scala/kafka/log/LogCleaner.scala 312204c6ddd0cf46cd7349d79a43edec839bc361
> core/src/main/scala/kafka/log/LogCleanerManager.scala 43e5c1fd6d9d99f6a47af2136a3d15b9799d4947
> core/src/main/scala/kafka/utils/Throttler.scala c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8
>
> Diff: https://reviews.apache.org/r/19947/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>
Re: Review Request 19947: Patch for KAFKA-1327
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19947/#review39540
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 2, 2014, 5:21 p.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19947/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 5:21 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1327
> https://issues.apache.org/jira/browse/KAFKA-1327
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1327 Add log cleaner metrics.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala b3ab5220a66a2ae82084dad89877daf60f613e66
> core/src/main/scala/kafka/log/LogCleaner.scala 312204c6ddd0cf46cd7349d79a43edec839bc361
> core/src/main/scala/kafka/log/LogCleanerManager.scala 43e5c1fd6d9d99f6a47af2136a3d15b9799d4947
> core/src/main/scala/kafka/utils/Throttler.scala c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8
>
> Diff: https://reviews.apache.org/r/19947/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>