You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (Created) (JIRA)" <ji...@apache.org> on 2011/11/03 00:29:32 UTC
[jira] [Created] (PIG-2346) TypeCastInsert should not insert
Foreach if there is no as statement
TypeCastInsert should not insert Foreach if there is no as statement
--------------------------------------------------------------------
Key: PIG-2346
URL: https://issues.apache.org/jira/browse/PIG-2346
Project: Pig
Issue Type: Bug
Affects Versions: 0.9.1, 0.10, 0.11
Reporter: Daniel Dai
Assignee: Daniel Dai
Fix For: 0.10, 0.9.2, 0.11
Currently, TypeCastInsert always insert foreach statement below the loader. But if the load statement doesn't have "as" clause, the foreach should not be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2346) TypeCastInsert should not insert
Foreach if there is no as statement
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143515#comment-13143515 ]
Ashutosh Chauhan commented on PIG-2346:
---------------------------------------
Daniel explained in this case there is a need to find out if schema is coming from as clause or through loadfunc. So, these new methods are required.
+1
> TypeCastInsert should not insert Foreach if there is no as statement
> --------------------------------------------------------------------
>
> Key: PIG-2346
> URL: https://issues.apache.org/jira/browse/PIG-2346
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.1, 0.10, 0.11
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.10, 0.9.2, 0.11
>
> Attachments: PIG-2346-1.patch, PIG-2346-2.patch
>
>
> Currently, TypeCastInsert always insert foreach statement below the loader. But if the load statement doesn't have "as" clause, the foreach should not be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2346) TypeCastInsert should not insert
Foreach if there is no as statement
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143456#comment-13143456 ]
Ashutosh Chauhan commented on PIG-2346:
---------------------------------------
Instead of adding new methods of getScriptSchema() I would expect getSchema() to return correct Schema and not null. It seems there is an underlying bug in LoLoad::getSchema().
> TypeCastInsert should not insert Foreach if there is no as statement
> --------------------------------------------------------------------
>
> Key: PIG-2346
> URL: https://issues.apache.org/jira/browse/PIG-2346
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.1, 0.10, 0.11
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.10, 0.9.2, 0.11
>
> Attachments: PIG-2346-1.patch, PIG-2346-2.patch
>
>
> Currently, TypeCastInsert always insert foreach statement below the loader. But if the load statement doesn't have "as" clause, the foreach should not be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-2346) TypeCastInsert should not insert
Foreach if there is no as statement
Posted by "Daniel Dai (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai resolved PIG-2346.
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
All tests pass. test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 6 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 468 release audit warnings (more than the trunk's current 459 warnings).
No new file added, ignore release audit warning.
Patch committed to 0.9 branch, 0.10 branch and trunk.
> TypeCastInsert should not insert Foreach if there is no as statement
> --------------------------------------------------------------------
>
> Key: PIG-2346
> URL: https://issues.apache.org/jira/browse/PIG-2346
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.1, 0.10, 0.11
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.10, 0.9.2, 0.11
>
> Attachments: PIG-2346-1.patch, PIG-2346-2.patch
>
>
> Currently, TypeCastInsert always insert foreach statement below the loader. But if the load statement doesn't have "as" clause, the foreach should not be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2346) TypeCastInsert should not insert
Foreach if there is no as statement
Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2346:
----------------------------
Attachment: PIG-2346-1.patch
> TypeCastInsert should not insert Foreach if there is no as statement
> --------------------------------------------------------------------
>
> Key: PIG-2346
> URL: https://issues.apache.org/jira/browse/PIG-2346
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.1, 0.10, 0.11
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.10, 0.9.2, 0.11
>
> Attachments: PIG-2346-1.patch
>
>
> Currently, TypeCastInsert always insert foreach statement below the loader. But if the load statement doesn't have "as" clause, the foreach should not be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2346) TypeCastInsert should not insert
Foreach if there is no as statement
Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2346:
----------------------------
Attachment: PIG-2346-2.patch
PIG-2346-2.patch fix unit test failures
> TypeCastInsert should not insert Foreach if there is no as statement
> --------------------------------------------------------------------
>
> Key: PIG-2346
> URL: https://issues.apache.org/jira/browse/PIG-2346
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.1, 0.10, 0.11
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.10, 0.9.2, 0.11
>
> Attachments: PIG-2346-1.patch, PIG-2346-2.patch
>
>
> Currently, TypeCastInsert always insert foreach statement below the loader. But if the load statement doesn't have "as" clause, the foreach should not be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira