[jira] [Commented] (NIFI-4818) Fix transit URL parsing at Hive2JDBC and KafkaTopic for ReportLineageToAtlas

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340419#comment-16340419 ] 

ASF GitHub Bot commented on NIFI-4818:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/2435

    NIFI-4818: Fix transit URL parsing at Hive2JDBC and KafkaTopic for Re…

    …portLineageToAtlas
    
    - Hive2JDBC: Handle connection parameters and multiple host entries
    correctly
    - KafkaTopic: Handle multiple host entries correctly
    - Avoid potential "IllegalStateException: Duplicate key" exception
    when NiFiAtlasHook analyzes existing NiFiFlowPath input/output entries
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-4818

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2435
    
----
commit 91ee885398128e796918a6fc6b98bdf442c5ebf1
Author: Koji Kawamura <ij...@...>
Date:   2018-01-25T04:57:01Z

    NIFI-4818: Fix transit URL parsing at Hive2JDBC and KafkaTopic for ReportLineageToAtlas
    
    - Hive2JDBC: Handle connection parameters and multiple host entries
    correctly
    - KafkaTopic: Handle multiple host entries correctly
    - Avoid potential "IllegalStateException: Duplicate key" exception
    when NiFiAtlasHook analyzes existing NiFiFlowPath input/output entries

----


> Fix transit URL parsing at Hive2JDBC and KafkaTopic for ReportLineageToAtlas
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-4818
>                 URL: https://issues.apache.org/jira/browse/NIFI-4818
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.5.0
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>            Priority: Major
>
> ReportLineageToAtlas parses Hive JDBC connection URLs to get database names. It works if a connection URL does not have parameters. (e.g. jdbc:hive2://host:port/dbName) But it reports wrong database name if there are parameters. E.g. with jdbc:hive2://host.port/dbName;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2, the reported database name will be dbName;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2, including the connection parameters.
> Also, if there are more than one host:port defined, it will not be able to analyze cluster name from hostnames correctly.
> Similarly for Kafka topic, the reporting task uses transit URIs to analyze hostnames and topic names. It does handle multiple host:port definitions within a URI, however, current logic only uses the first hostname entry even if there are multiple ones. For example, with a transit URI, "PLAINTEXT://0.example.com:6667,1.example.com:6667/topicA", it uses "0.example.com" to match configured regular expressions to derive a cluster name. If none of regex matches, then it uses the default cluster name without looping through all hostnames. It never uses the 2nd or later hostnames to derive a cluster name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)