You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "vimukthiD (via GitHub)" <gi...@apache.org> on 2025/01/09 06:17:59 UTC
[PR] NET-727 enable accessing options map for TFTP request packet [commons-net]
vimukthiD opened a new pull request, #318:
URL: https://github.com/apache/commons-net/pull/318
relates to existing https://issues.apache.org/jira/browse/NET-727
This changes only includes the mapping of `options` map in TFTPRequestPacket which would be towards implementing RFC2347. For my use case only requirement was to get the `blksize` (RFC2348) from the request packet and would like to move on to try my luck with implementing the RFC2347.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NET-727 enable accessing options map for TFTP request packet [commons-net]
Posted by "vimukthiD (via GitHub)" <gi...@apache.org>.
vimukthiD commented on code in PR #318:
URL: https://github.com/apache/commons-net/pull/318#discussion_r1916657757
##########
src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java:
##########
@@ -56,6 +59,9 @@ public abstract class TFTPRequestPacket extends TFTPPacket {
/** The file name of the request. */
private final String fileName;
+ /** The option values */
+ private Map<String, String> options = new HashMap<>();
Review Comment:
I've updated the `TFTPErrorPacket` to have the error code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NET-727 enable accessing options map for TFTP request packet [commons-net]
Posted by "vimukthiD (via GitHub)" <gi...@apache.org>.
vimukthiD closed pull request #318: NET-727 enable accessing options map for TFTP request packet
URL: https://github.com/apache/commons-net/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NET-727 enable accessing options map for TFTP request packet [commons-net]
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on code in PR #318:
URL: https://github.com/apache/commons-net/pull/318#discussion_r1913876378
##########
src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java:
##########
@@ -56,6 +59,9 @@ public abstract class TFTPRequestPacket extends TFTPPacket {
/** The file name of the request. */
private final String fileName;
+ /** The option values */
+ private Map<String, String> options = new HashMap<>();
Review Comment:
I think `options` can be `final`.
##########
src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java:
##########
@@ -56,6 +59,9 @@ public abstract class TFTPRequestPacket extends TFTPPacket {
/** The file name of the request. */
private final String fileName;
+ /** The option values */
+ private Map<String, String> options = new HashMap<>();
Review Comment:
According to _rfc2347_. A new error code with value `8` is defined to indicate that a transfer should be terminated due to option negotiation. I think you can safely add new err code to `TFTPErrorPacket` ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NET-727 enable accessing options map for TFTP request packet [commons-net]
Posted by "vimukthiD (via GitHub)" <gi...@apache.org>.
vimukthiD commented on code in PR #318:
URL: https://github.com/apache/commons-net/pull/318#discussion_r1916654705
##########
src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java:
##########
@@ -56,6 +59,9 @@ public abstract class TFTPRequestPacket extends TFTPPacket {
/** The file name of the request. */
private final String fileName;
+ /** The option values */
+ private Map<String, String> options = new HashMap<>();
Review Comment:
thank you for pointing that out , I've changed it to be `final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org