[GitHub] [beam] fbeevikm commented on a diff in pull request #17741: [BEAM-14504] Add support for including addittional parameters to executebundle method in fhirio.

[GitBox <gi...@apache.org>]

fbeevikm commented on code in PR #17741:
URL: https://github.com/apache/beam/pull/17741#discussion_r888192448


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleResponseCoder.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.healthcare;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import org.apache.beam.sdk.coders.CustomCoder;
+import org.apache.beam.sdk.coders.NullableCoder;
+import org.apache.beam.sdk.coders.StringUtf8Coder;
+
+public class FhirBundleResponseCoder extends CustomCoder<FhirBundleResponse> {
+  private static final NullableCoder<String> STRING_CODER = NullableCoder.of(StringUtf8Coder.of());
+  private final FhirBundleParameterCoder fhirBundleParameterCoder = FhirBundleParameterCoder.of();
+
+  public static FhirBundleResponseCoder of() {
+    return new FhirBundleResponseCoder();
+  }
+
+  @Override
+  public void encode(FhirBundleResponse value, OutputStream outStream) throws IOException {
+    fhirBundleParameterCoder.encode(value.getFhirBundleParameter(), outStream);
+    STRING_CODER.encode(value.getResponse(), outStream);
+  }
+
+  @Override
+  public FhirBundleResponse decode(InputStream inStream) throws IOException {
+    FhirBundleParameter fhirBundleParameter = fhirBundleParameterCoder.decode(inStream);
+    String response = STRING_CODER.decode(inStream);
+    return FhirBundleResponse.of(fhirBundleParameter, response);

Review Comment:
   done



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleParameterCoder.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.healthcare;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import org.apache.beam.sdk.coders.CustomCoder;
+import org.apache.beam.sdk.coders.NullableCoder;
+import org.apache.beam.sdk.coders.StringUtf8Coder;
+
+/** Coder for {@link FhirBundleParameter}. */
+public class FhirBundleParameterCoder extends CustomCoder<FhirBundleParameter> {
+  private static final NullableCoder<String> STRING_CODER = NullableCoder.of(StringUtf8Coder.of());
+
+  public static FhirBundleParameterCoder of() {
+    return new FhirBundleParameterCoder();
+  }
+
+  @Override
+  public void encode(FhirBundleParameter value, OutputStream outStream) throws IOException {
+    STRING_CODER.encode(value.getMetadata(), outStream);
+    STRING_CODER.encode(value.getBundle(), outStream);
+  }
+
+  @Override
+  public FhirBundleParameter decode(InputStream inStream) throws IOException {
+    String metadata = STRING_CODER.decode(inStream);
+    String bundle = STRING_CODER.decode(inStream);
+    return FhirBundleParameter.of(metadata, bundle);
+  }
+}

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org