[GitHub] [systemds] ywcb00 opened a new pull request #1245: [SYSTEMDS-2960] Codegen: POS replacement for elementwise binary operations

[GitBox <gi...@apache.org>]

ywcb00 opened a new pull request #1245:
URL: https://github.com/apache/systemds/pull/1245


   Hi,
   I tried to correctly replace the position for calls to elementwise binary operations of "SideInputs" (b) with column vectors.
   In my opinion, we need to do include the row index in the very same way as for matrices if it is an (1) elementwise operation with a (2) column vector.
   
   Thank you for reviewing and commenting :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] mboehm7 commented on pull request #1245: [SYSTEMDS-2960] Codegen: POS replacement for elementwise binary operations

[GitBox <gi...@apache.org>]

mboehm7 commented on pull request #1245:
URL: https://github.com/apache/systemds/pull/1245#issuecomment-841248827


   LGTM - thanks for catching this issue @ywcb00.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] asfgit closed pull request #1245: [SYSTEMDS-2960] Codegen: POS replacement for elementwise binary operations

[GitBox <gi...@apache.org>]

asfgit closed pull request #1245:
URL: https://github.com/apache/systemds/pull/1245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org