***UNCHECKED*** [jira] [Commented] (ARTEMIS-550) Add support for virtual topic consumers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341296#comment-16341296 ] 

ASF GitHub Bot commented on ARTEMIS-550:
----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1820#discussion_r164167446
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java ---
    @@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final ActiveMQDestination dest,
                  */
                 if (!response.isExists() || !response.getQueueNames().contains(dest.getSimpleAddress())) {
                    if (response.isAutoCreateQueues()) {
    +                  SimpleString queueNameToUse = dest.getSimpleAddress();
    +                  SimpleString addressToUse = queueNameToUse;
    +                  RoutingType routingTypeToUse = RoutingType.ANYCAST;
    +                  if (CompositeAddress.isFullyQualified(queueNameToUse.toString())) {
    +                     CompositeAddress compositeAddress = CompositeAddress.getQueueName(queueNameToUse.toString());
    +                     addressToUse = new SimpleString(compositeAddress.getAddress());
    +                     queueNameToUse = new SimpleString(compositeAddress.getQueueName());
    +                     routingTypeToUse = RoutingType.MULTICAST;
    --- End diff --
    
    No they don’t. Please see spec. Client ID is optional for a shared subscription.  Using a SharedDurableConsumer without setting a client id will give you queue like consuming semantics on a JMS Topic


> Add support for virtual topic consumers
> ---------------------------------------
>
>                 Key: ARTEMIS-550
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-550
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 1.3.0
>            Reporter: Benjamin Graf
>            Assignee: Martyn Taylor
>            Priority: Major
>         Attachments: image-2018-01-26-09-02-08-192.png
>
>
> Artemis should support virtual topic consumers as alternative to topic subscriptions as ActiveMQ itself does.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)