You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "jnturton (via GitHub)" <gi...@apache.org> on 2023/03/16 14:14:32 UTC
[PR] DRILL-8409: Support the configuration of bind addresses for network services (drill)
jnturton opened a new pull request, #2777:
URL: https://github.com/apache/drill/pull/2777
# [DRILL-8409](https://issues.apache.org/jira/browse/DRILL-8409): Support the configuration of bind addresses for network services
## Description
Drill provides the DRILL_HOST_NAME env var which determines what Drillbit host name will be exchanged over RPC for later look up by a remote client or Drillbit. This host name is used to check whether Drill is being asked to bind to the loopback address in distributed mode
```
if (isDistributedMode && InetAddress.getByName(hostName).isLoopbackAddress()) {
throw new DrillbitStartupException("Drillbit is disallowed to bind to loopback address in distributed mode.");
}
```
but is not ever used set the bind address used for the Drillbit's RPC and web ports! This PR adds new boot options
```
drill.exec.rpc.bind_addr
drill.exec.http.bind_addr
```
and uses them to set the bind addresses used for RPC services and the HTTP service respectively.
## Documentation
Document all three of DRILL_HOST_NAME and the two new bind address options.
## Testing
Provide no bind addresses and confirm that the effective previous default (0.0.0.0) is applied.
Manually set bind addresses and test that Drill is not accessible on other local addresses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8409: Support the configuration of bind addresses for network services (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton merged PR #2777:
URL: https://github.com/apache/drill/pull/2777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8409: Support the configuration of bind addresses for network services (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2777:
URL: https://github.com/apache/drill/pull/2777#issuecomment-1490042016
> LGTM +1. Do we need any doc updates for this?
Documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8409: Support the configuration of bind addresses for network services (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2777:
URL: https://github.com/apache/drill/pull/2777#issuecomment-1490042762
> @jnturton Sorry for the late review. The only thing that I would add is a mention of `drill.exec.rpc.bind_addr` and `drill.exec.http.bind_addr` in [`drill-override-example.conf`](https://github.com/apache/drill/blob/master/distribution/src/main/resources/drill-override-example.conf) if this file is still maintainable of course. In addition to our documentation.
See #2782 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8409: Support the configuration of bind addresses for network services (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2777:
URL: https://github.com/apache/drill/pull/2777#issuecomment-1488817097
> LGTM +1. Do we need any doc updates for this?
Yes I need to document the two new boot options, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8409: Support the configuration of bind addresses for network services (drill)
Posted by "rymarm (via GitHub)" <gi...@apache.org>.
rymarm commented on PR #2777:
URL: https://github.com/apache/drill/pull/2777#issuecomment-1489063820
@jnturton Sorry for the late review. The only thing that I would add is a mention of `drill.exec.rpc.bind_addr` and `drill.exec.http.bind_addr` in [`drill-override-example.conf`](https://github.com/apache/drill/blob/master/distribution/src/main/resources/drill-override-example.conf) if this file is still maintainable of course. In addition to our documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8409: Support the configuration of bind addresses for network services (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2777:
URL: https://github.com/apache/drill/pull/2777#issuecomment-1473742795
I've added two unrelated minor changes implementing safe calls to close() methods. Currently when these calls fail due to some earlier error they drown interesting messages out in unhelpful NPE noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org