You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/12 08:43:36 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1038: Client-side URL redirect
juzhiyuan opened a new issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038
# Bug report
## Describe the bug
https://github.com/apache/apisix-dashboard/security/code-scanning/3?query=ref%3Arefs%2Fheads%2Fmaster
Redirecting to a URL that is constructed from parts of the DOM that may be controlled by an attacker can facilitate phishing attacks. In these attacks, unsuspecting users can be redirected to a malicious site that looks very similar to the real site they intend to visit, but which is controlled by the attacker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1038: Client-side URL redirect
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038#issuecomment-758611015
Hi @ThanoshanMV, here is the explanation from GitHub, we should limit the `redirect` URL, it MUST do the redirect action with the current host.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1038: Client-side URL redirect
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038#issuecomment-743725172
We may limit the target redirect URL to have the same host as the current URL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1038: Client-side URL redirect
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038#issuecomment-757919536
@ThanoshanMV sure! please give me some time to prepare this issue.
BTW, here[1] is our Slack channel, welcome to join in :)
[1] http://s.apache.org/slack-invite
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ThanoshanMV commented on issue #1038: Client-side URL redirect
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038#issuecomment-757899796
Hi @juzhiyuan, I would like to work on this issue. Can you please guide me here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1038: Client-side URL redirect
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038#issuecomment-759155233
@ThanoshanMV yep :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran closed issue #1038: Client-side URL redirect
Posted by GitBox <gi...@apache.org>.
liuxiran closed issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ThanoshanMV commented on issue #1038: Client-side URL redirect
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #1038:
URL: https://github.com/apache/apisix-dashboard/issues/1038#issuecomment-758728668
Am I okay here: `decodeURIComponent(redirect)`'s host should be the current host. If it is, then we'll perform the redirect action and if it doesn't, we don't perform any redirect action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org