You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Quanlong Huang <hu...@gmail.com> on 2023/01/28 00:12:18 UTC
Looking for reviewers for a trivial fix
Hi team,
I'm new to the Thrift community. I submitted a PR that fixes a trivial log
issue two months ago:
https://github.com/apache/thrift/pull/2732
https://issues.apache.org/jira/browse/THRIFT-5670
Didn't get replies from the initial reviewer. Could someone help to take
a look?
Thanks,
Quanlong Huang
Fix a confusing error message in the cpp lib
Posted by Quanlong Huang <hu...@gmail.com>.
Hi team,
We are using the cpp thrift lib and have seen some confusing logs like
I1017 17:14:55.800310 195900 thrift-util.cc:106] TSocket::read()
THRIFT_EAGAIN (timed out) after %f ms: Unknown error 30000
I1017 17:15:25.830340 195900 thrift-util.cc:106] TSocket::read()
THRIFT_EAGAIN (timed out) after %f ms: Unknown error 30000
After some debugging, I realized it's complaining about timed out after
30000ms. So I raised a JIRA (THRIFT-5670
<https://issues.apache.org/jira/browse/THRIFT-5670>) and a PR to fix it (11
months ago): https://github.com/apache/thrift/pull/2732 . It's just a
one-line change.
emmenlau helps to take the initial review. But didn't get back from him/her
this year. Can someone kindly help to review it?
Thanks,
Quanlong
On Sat, Jan 28, 2023 at 8:12 AM Quanlong Huang <hu...@gmail.com>
wrote:
> Hi team,
>
> I'm new to the Thrift community. I submitted a PR that fixes a trivial log
> issue two months ago:
> https://github.com/apache/thrift/pull/2732
> https://issues.apache.org/jira/browse/THRIFT-5670
>
> Didn't get replies from the initial reviewer. Could someone help to take
> a look?
>
> Thanks,
> Quanlong Huang
>