You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (Commented) (JIRA)" <ji...@apache.org> on 2011/11/24 20:52:40 UTC
[jira] [Commented] (SOLR-2912) File descriptor leak in
ShowFileRequestHandler.getFileContents()
[ https://issues.apache.org/jira/browse/SOLR-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156885#comment-13156885 ]
Hoss Man commented on SOLR-2912:
--------------------------------
Michael: thanks for catching this bug!
FWIW: I'm pretty sure this method is only used by the main index.jsp page to include the "admin-extra.html" file -- I don't believe it's used by regular usage of the ShowFileRequestHandler (ie: to view the schema.xml or solrconfig.xml files)
so i _think_ only users who leverage that feature (which i suspect is probably not a very large number since it isn't really advertised much) would have been bitten by this bug. (which also explains why no one noticed it until now)
> File descriptor leak in ShowFileRequestHandler.getFileContents()
> ----------------------------------------------------------------
>
> Key: SOLR-2912
> URL: https://issues.apache.org/jira/browse/SOLR-2912
> Project: Solr
> Issue Type: Bug
> Components: web gui
> Affects Versions: 3.2
> Reporter: Michael Ryan
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2912.patch
>
>
> There is a file descriptor leak in ShowFileRequestHandler.getFileContents() - the InputStream is not closed. This could cause a "Too many open files" error if the admin page is loaded a lot.
> I've only tested this on 3.2, but I think it affects all recent versions, including trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org