You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2017/05/10 13:51:07 UTC

Review Request 59142: ATLAS-1756 : Allow user to edit associated Tag (classification)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59142/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-1756
    https://issues.apache.org/jira/browse/ATLAS-1756


Repository: atlas


Description
-------

This patch contains changes which allows user to edit associated tag attributes(Classification)


Diffs
-----

  dashboardv2/public/css/scss/main.scss 3e6e77f 
  dashboardv2/public/js/main.js 39e6d57 
  dashboardv2/public/js/models/VEntity.js 88310ab 
  dashboardv2/public/js/router/Router.js db5bc1f 
  dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 3ca2658 
  dashboardv2/public/js/utils/UrlLinks.js bdeda8d 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js dc3ae4c 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 75714f0 
  dashboardv2/public/js/views/search/SearchDetailLayoutView.js d44eb78 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js b2f24d4 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 677058b 
  dashboardv2/public/js/views/tag/addTagModalView.js 01e1dfd 


Diff: https://reviews.apache.org/r/59142/diff/1/


Testing
-------

* Under tag tab Edit button has been added besides attributes column in tag detail table.
* By clicking on Edit button, pop window with existing values of attributes is shown.
* Existing values are editable.
* By clicking on Update button, tag gets updated with new values also its shows successfull updation message.
* Edit button for deleted entity is not displayed.


Thanks,

keval bhatt


Re: Review Request 59142: ATLAS-1756 : Allow user to edit associated Tag (classification)

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59142/#review174539
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 11, 2017, 12:37 p.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59142/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 12:37 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1756
>     https://issues.apache.org/jira/browse/ATLAS-1756
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch contains changes which allows user to edit associated tag attributes(Classification)
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/main.scss 3e6e77f 
>   dashboardv2/public/js/main.js 39e6d57 
>   dashboardv2/public/js/models/VEntity.js 88310ab 
>   dashboardv2/public/js/router/Router.js db5bc1f 
>   dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 3ca2658 
>   dashboardv2/public/js/utils/UrlLinks.js bdeda8d 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js dc3ae4c 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js e7f0f6e 
>   dashboardv2/public/js/views/search/SearchDetailLayoutView.js d44eb78 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 314e137 
>   dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 677058b 
>   dashboardv2/public/js/views/tag/addTagModalView.js 01e1dfd 
> 
> 
> Diff: https://reviews.apache.org/r/59142/diff/2/
> 
> 
> Testing
> -------
> 
> * Under tag tab Edit button has been added besides attributes column in tag detail table.
> * By clicking on Edit button, pop window with existing values of attributes is shown.
> * Existing values are editable.
> * By clicking on Update button, tag gets updated with new values also its shows successfull updation message.
> * Edit button for deleted entity is not displayed.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


Re: Review Request 59142: ATLAS-1756 : Allow user to edit associated Tag (classification)

Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59142/
-----------------------------------------------------------

(Updated May 11, 2017, 12:37 p.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Rebased the patch with master


Bugs: ATLAS-1756
    https://issues.apache.org/jira/browse/ATLAS-1756


Repository: atlas


Description
-------

This patch contains changes which allows user to edit associated tag attributes(Classification)


Diffs (updated)
-----

  dashboardv2/public/css/scss/main.scss 3e6e77f 
  dashboardv2/public/js/main.js 39e6d57 
  dashboardv2/public/js/models/VEntity.js 88310ab 
  dashboardv2/public/js/router/Router.js db5bc1f 
  dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 3ca2658 
  dashboardv2/public/js/utils/UrlLinks.js bdeda8d 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js dc3ae4c 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js e7f0f6e 
  dashboardv2/public/js/views/search/SearchDetailLayoutView.js d44eb78 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 314e137 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 677058b 
  dashboardv2/public/js/views/tag/addTagModalView.js 01e1dfd 


Diff: https://reviews.apache.org/r/59142/diff/2/

Changes: https://reviews.apache.org/r/59142/diff/1-2/


Testing
-------

* Under tag tab Edit button has been added besides attributes column in tag detail table.
* By clicking on Edit button, pop window with existing values of attributes is shown.
* Existing values are editable.
* By clicking on Update button, tag gets updated with new values also its shows successfull updation message.
* Edit button for deleted entity is not displayed.


Thanks,

keval bhatt