You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/08/20 18:17:46 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
sv2000 opened a new pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087
…publishing
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1246
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Currently, publishing of staging artifacts to the Apache Nexus repository is broken. This task modifies build scripts to fix the Nexus artifact publish.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Ran nexusPublish step with local option.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087#discussion_r474402430
##########
File path: gradle/scripts/nexusPublishing.gradle
##########
@@ -64,6 +64,74 @@ gradle.taskGraph.afterTask {
}
}
+ext.pomAttributes = {
+ packaging 'jar'
+ // optionally artifactId can be defined here
+ name 'Apache Gobblin (incubating)'
+ description 'A distributed data integration framework for streaming and batch data ecosystems.'
+ url 'https://gobblin.apache.org/'
+
+ scm {
+ url 'https://git-wip-us.apache.org/repos/asf?p=incubator-gobblin.git;a=tree'
+ connection 'scm:http://git-wip-us.apache.org/repos/asf/incubator-gobblin.git'
+ developerConnection 'scm:https://git-wip-us.apache.org/repos/asf/incubator-gobblin.git'
+ }
+
+ licenses {
+ license {
+ name 'The Apache License, Version 2.0'
+ url 'http://www.apache.org/licenses/LICENSE-2.0.txt'
+ }
+ }
+
+ developers {
Review comment:
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] vikrambohra commented on a change in pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
Posted by GitBox <gi...@apache.org>.
vikrambohra commented on a change in pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087#discussion_r474242929
##########
File path: gradle/scripts/nexusPublishing.gradle
##########
@@ -64,6 +64,74 @@ gradle.taskGraph.afterTask {
}
}
+ext.pomAttributes = {
Review comment:
Can we update and reuse the pomAttributes from bintrayPublishing.gradle? Idea is to have just one location for pom attributes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087#issuecomment-677824622
@vikrambohra Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] vikrambohra commented on a change in pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
Posted by GitBox <gi...@apache.org>.
vikrambohra commented on a change in pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087#discussion_r474405733
##########
File path: gobblin-service/build.gradle
##########
@@ -91,12 +91,27 @@ dependencies {
// Begin HACK to get around POM being depenendent on the (empty) gobblin-rest-api instead of gobblin-rest-api-rest-client
def installer = install.repositories.mavenInstaller
[installer]*.pom*.whenConfigured {pom ->
- pom.dependencies.find {dep -> dep.groupId == project.group && dep.artifactId == 'gobblin-flow-config-service-api' }.artifactId = 'gobblin-flow-config-service-api-rest-client'
+ def it = pom.dependencies
+ def s = it.find {dep -> dep.groupId == project.group && dep.artifactId == 'gobblin-flow-config-service-api' }
+ if (s != null) {
+ def t = s.clone()
+ t.artifactId = 'gobblin-flow-config-service-api-data-template'
+ it.add(t)
+ s.artifactId = 'gobblin-flow-config-service-api-rest-client'
+ }
}
+
if (rootProject.publishToMaven || rootProject.publishToNexus) {
def deployer = uploadArchives.repositories.mavenDeployer
[deployer]*.pom*.whenConfigured {pom ->
- pom.dependencies.find {dep -> dep.groupId == project.group && dep.artifactId == 'gobblin-flow-config-service-api' }.artifactId = 'gobblin-flow-config-service-api-rest-client'
+ def it = pom.dependencies
+ def s = it.find {dep -> dep.groupId == project.group && dep.artifactId == 'gobblin-flow-config-service-api' }
+ if (s != null) {
+ def t = s.clone()
+ t.artifactId = 'gobblin-flow-config-service-api-data-template'
Review comment:
good call adding gobblin-flow-config-service-api also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087#issuecomment-677822445
@htran1 @abti Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] abti commented on a change in pull request #3087: GOBBLIN-1246: Modify build scripts to fix failures in Nexus artifact …
Posted by GitBox <gi...@apache.org>.
abti commented on a change in pull request #3087:
URL: https://github.com/apache/incubator-gobblin/pull/3087#discussion_r474399480
##########
File path: gradle/scripts/nexusPublishing.gradle
##########
@@ -64,6 +64,74 @@ gradle.taskGraph.afterTask {
}
}
+ext.pomAttributes = {
+ packaging 'jar'
+ // optionally artifactId can be defined here
+ name 'Apache Gobblin (incubating)'
+ description 'A distributed data integration framework for streaming and batch data ecosystems.'
+ url 'https://gobblin.apache.org/'
+
+ scm {
+ url 'https://git-wip-us.apache.org/repos/asf?p=incubator-gobblin.git;a=tree'
+ connection 'scm:http://git-wip-us.apache.org/repos/asf/incubator-gobblin.git'
+ developerConnection 'scm:https://git-wip-us.apache.org/repos/asf/incubator-gobblin.git'
+ }
+
+ licenses {
+ license {
+ name 'The Apache License, Version 2.0'
+ url 'http://www.apache.org/licenses/LICENSE-2.0.txt'
+ }
+ }
+
+ developers {
Review comment:
please remove this section. Ideally, the committers should be maintained outside of gradle, and this list is outdated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org