You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jean-Francois Vincent <je...@atos.net> on 2014/04/03 15:06:22 UTC
Review Request 19995: VM Userdata field at GUI VM creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
VM creation user interface : added the Userdata field
Diffs
-----
client/WEB-INF/classes/resources/messages.properties 8abe874
ui/index.jsp 4910b9f
ui/scripts/instanceWizard.js c2d3030
Diff: https://reviews.apache.org/r/19995/diff/
Testing
-------
tested done on 4.2.1. This patch was adapted for last master branch.
Thanks,
Jean-Francois Vincent
Re: Review Request 19995: VM Userdata field at GUI VM creation
Posted by Axel Delahaye <ax...@worldline.com>.
> On déc. 5, 2014, 9:43 après-midi, Pierre-Luc Dion wrote:
> > Does the feature include the capability to update or change userdata once the VM is created?
No, it is an optional textarea in the instanceWizard
- Axel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/#review64088
-----------------------------------------------------------
On déc. 5, 2014, 5:56 après-midi, Jean-Francois Vincent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19995/
> -----------------------------------------------------------
>
> (Updated déc. 5, 2014, 5:56 après-midi)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VM creation user interface : added the Userdata field
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 8abe874
> ui/index.jsp 4910b9f
> ui/scripts/instanceWizard.js c2d3030
>
> Diff: https://reviews.apache.org/r/19995/diff/
>
>
> Testing
> -------
>
> tested done on 4.2.1. This patch was adapted for last master branch.
>
>
> Thanks,
>
> Jean-Francois Vincent
>
>
Re: Review Request 19995: VM Userdata field at GUI VM creation
Posted by Pierre-Luc Dion <pd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/#review64088
-----------------------------------------------------------
Does the feature include the capability to update or change userdata once the VM is created?
- Pierre-Luc Dion
On Dec. 5, 2014, 5:56 p.m., Jean-Francois Vincent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19995/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 5:56 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VM creation user interface : added the Userdata field
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 8abe874
> ui/index.jsp 4910b9f
> ui/scripts/instanceWizard.js c2d3030
>
> Diff: https://reviews.apache.org/r/19995/diff/
>
>
> Testing
> -------
>
> tested done on 4.2.1. This patch was adapted for last master branch.
>
>
> Thanks,
>
> Jean-Francois Vincent
>
>
Re: Review Request 19995: VM Userdata field at GUI VM creation
Posted by Jean-Francois Vincent <je...@atos.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 5:56 p.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Repository: cloudstack-git
Description
-------
VM creation user interface : added the Userdata field
Diffs
-----
client/WEB-INF/classes/resources/messages.properties 8abe874
ui/index.jsp 4910b9f
ui/scripts/instanceWizard.js c2d3030
Diff: https://reviews.apache.org/r/19995/diff/
Testing
-------
tested done on 4.2.1. This patch was adapted for last master branch.
Thanks,
Jean-Francois Vincent
Re: Review Request 19995: VM Userdata field at GUI VM creation
Posted by Rohit Yadav <bh...@apache.org>.
> On Dec. 5, 2014, 5:55 p.m., Rohit Yadav wrote:
> > Interesting feature, can you send another patch that applies cleanly on master? I'll add known UI contributors who may help review your patch.
>
> Axel Delahaye wrote:
> I have the new diff but I can't upload it for J.F. Vincent
Send it separetely, Github PR on github.com/apache/cloudstack (Github is more fun that ReviewBoard), I see you both have atos.net in email (assuming you're both colleagues).
Once we've that PR we can close this review request.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/#review64022
-----------------------------------------------------------
On Dec. 5, 2014, 5:56 p.m., Jean-Francois Vincent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19995/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 5:56 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VM creation user interface : added the Userdata field
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 8abe874
> ui/index.jsp 4910b9f
> ui/scripts/instanceWizard.js c2d3030
>
> Diff: https://reviews.apache.org/r/19995/diff/
>
>
> Testing
> -------
>
> tested done on 4.2.1. This patch was adapted for last master branch.
>
>
> Thanks,
>
> Jean-Francois Vincent
>
>
Re: Review Request 19995: VM Userdata field at GUI VM creation
Posted by Axel Delahaye <ax...@worldline.com>.
> On déc. 5, 2014, 5:55 après-midi, Rohit Yadav wrote:
> > Interesting feature, can you send another patch that applies cleanly on master? I'll add known UI contributors who may help review your patch.
I have the new diff but I can't upload it for J.F. Vincent
- Axel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/#review64022
-----------------------------------------------------------
On déc. 5, 2014, 5:56 après-midi, Jean-Francois Vincent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19995/
> -----------------------------------------------------------
>
> (Updated déc. 5, 2014, 5:56 après-midi)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VM creation user interface : added the Userdata field
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 8abe874
> ui/index.jsp 4910b9f
> ui/scripts/instanceWizard.js c2d3030
>
> Diff: https://reviews.apache.org/r/19995/diff/
>
>
> Testing
> -------
>
> tested done on 4.2.1. This patch was adapted for last master branch.
>
>
> Thanks,
>
> Jean-Francois Vincent
>
>
Re: Review Request 19995: VM Userdata field at GUI VM creation
Posted by Axel Delahaye <ax...@worldline.com>.
> On déc. 5, 2014, 5:55 après-midi, Rohit Yadav wrote:
> > Interesting feature, can you send another patch that applies cleanly on master? I'll add known UI contributors who may help review your patch.
>
> Axel Delahaye wrote:
> I have the new diff but I can't upload it for J.F. Vincent
>
> Rohit Yadav wrote:
> Send it separetely, Github PR on github.com/apache/cloudstack (Github is more fun that ReviewBoard), I see you both have atos.net in email (assuming you're both colleagues).
> Once we've that PR we can close this review request.
done, PR #55
- Axel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/#review64022
-----------------------------------------------------------
On déc. 5, 2014, 5:56 après-midi, Jean-Francois Vincent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19995/
> -----------------------------------------------------------
>
> (Updated déc. 5, 2014, 5:56 après-midi)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VM creation user interface : added the Userdata field
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 8abe874
> ui/index.jsp 4910b9f
> ui/scripts/instanceWizard.js c2d3030
>
> Diff: https://reviews.apache.org/r/19995/diff/
>
>
> Testing
> -------
>
> tested done on 4.2.1. This patch was adapted for last master branch.
>
>
> Thanks,
>
> Jean-Francois Vincent
>
>
Re: Review Request 19995: VM Userdata field at GUI VM creation
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19995/#review64022
-----------------------------------------------------------
Interesting feature, can you send another patch that applies cleanly on master? I'll add known UI contributors who may help review your patch.
- Rohit Yadav
On April 3, 2014, 1:06 p.m., Jean-Francois Vincent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19995/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 1:06 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VM creation user interface : added the Userdata field
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 8abe874
> ui/index.jsp 4910b9f
> ui/scripts/instanceWizard.js c2d3030
>
> Diff: https://reviews.apache.org/r/19995/diff/
>
>
> Testing
> -------
>
> tested done on 4.2.1. This patch was adapted for last master branch.
>
>
> Thanks,
>
> Jean-Francois Vincent
>
>