You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ibrusentsev (via GitHub)" <gi...@apache.org> on 2023/11/13 13:02:19 UTC
[PR] HDDS-9681. Allow OM to detect client address when using gRPC [ozone]
ibrusentsev opened a new pull request, #5591:
URL: https://github.com/apache/ozone/pull/5591
## What changes were proposed in this pull request?
### Motivation
The RATIS object reading is currently implemented using a gRPC client (specifically, the BlockInputStream.getChunkInfos() method switches the pipeline type to STANDALONE, and the XceiverClientManager selects a gRPC client). Unfortunately, this configuration does not allow the Ozone Manager to determine the client's host address since the OmMetadatareader.getClientAddress() method only works for Hadoop RPC interactions. This failure to detect the client's address results in an empty nodesInOrder field in the response received by the client, causing the datanodes to be read in the default order in the pipeline, with the leader node being read first.
### Solution
Аdded possibility to define client address for gRPC calls. This helps to define closest node for read RATIS/THREE objects.
P.S. This patch was split from https://github.com/apache/ozone/pull/5574 Pull request.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9651
https://issues.apache.org/jira/browse/HDDS-9681
## How was this patch tested?
Manual test with following steps:
1. create an RATIS/THREE object in a cluster;
2. read object several times from one of pipeline's datanode where object stored;
3. check metrics - all read transactions were done from datanode where read requested (local copy is used);
4. repeat p. 2-3 on other nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9681. Allow OM to detect client address when using gRPC [ozone]
Posted by "ibrusentsev (via GitHub)" <gi...@apache.org>.
ibrusentsev closed pull request #5591: HDDS-9681. Allow OM to detect client address when using gRPC
URL: https://github.com/apache/ozone/pull/5591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9681. Allow OM to detect client address when using gRPC [ozone]
Posted by "ibrusentsev (via GitHub)" <gi...@apache.org>.
ibrusentsev commented on PR #5591:
URL: https://github.com/apache/ozone/pull/5591#issuecomment-1808220772
@adoroszlai thanks for noticing, we are discussing with @vtutrinov some common solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9681. Allow OM to detect client address when using gRPC [ozone]
Posted by "ibrusentsev (via GitHub)" <gi...@apache.org>.
ibrusentsev commented on PR #5591:
URL: https://github.com/apache/ozone/pull/5591#issuecomment-1811879865
Will be done in scope of https://github.com/apache/ozone/pull/5590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9681. Allow OM to detect client address when using gRPC [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5591:
URL: https://github.com/apache/ozone/pull/5591#issuecomment-1808131582
Thanks @ibrusentsev for extracting this from #5574. I just found that @vtutrinov has been working on similar change in #5590.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org