You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/12/23 16:05:20 UTC

[GitHub] [storm] bipinprasad commented on a change in pull request #3368: [STORM-3729] fix assgin memory error over 2g

bipinprasad commented on a change in pull request #3368:
URL: https://github.com/apache/storm/pull/3368#discussion_r548029960



##########
File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java
##########
@@ -1039,7 +1039,7 @@ public static Double parseJvmHeapMemByChildOpts(List<String> options, Double def
                 }
                 Matcher m = optsPattern.matcher(option);
                 while (m.find()) {
-                    int value = Integer.parseInt(m.group(1));
+                    long value = Long.parseLong(m.group(1));

Review comment:
       Even for several gigabytes, the number is still smaller than Integer.MAX_VALUE iin term of "m", "k" or "g" units, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org