[cordova-paramedic] 01/02: TODOs

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-split_build_and_run
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 03526974380f44e8dd632d6c0619b4fd10c2d297
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sat Jun 29 18:04:30 2019 +0200

    TODOs
---
 lib/LocalServer.js        |  3 +++
 lib/ParamedicSauceLabs.js |  3 +++
 lib/paramedic.js          | 11 +++++++++++
 3 files changed, 17 insertions(+)

diff --git a/lib/LocalServer.js b/lib/LocalServer.js
index 5d7d2f4..b00cf61 100644
--- a/lib/LocalServer.js
+++ b/lib/LocalServer.js
@@ -156,6 +156,9 @@ function getRandomInt (min, max) {
 }
 
 LocalServer.startServer = function (ports, externalServerUrl, useTunnel, noListener) {
+
+    // TODO 2. Create and configure local server to receive test results
+
     logger.normal('local-server: scanning ports from ' + ports.start + ' to ' + ports.end);
 
     return LocalServer.getAvailablePort(ports.start, ports.end)
diff --git a/lib/ParamedicSauceLabs.js b/lib/ParamedicSauceLabs.js
index b9b8718..538a9b6 100644
--- a/lib/ParamedicSauceLabs.js
+++ b/lib/ParamedicSauceLabs.js
@@ -382,6 +382,9 @@ class ParamedicSauceLabs {
     }
 
     runSauceTests () {
+
+        // TODO 3a. ... on SauceLabs
+
         let isTestPassed = false;
         let pollForResults;
         let driver;
diff --git a/lib/paramedic.js b/lib/paramedic.js
index a70607f..171d274 100644
--- a/lib/paramedic.js
+++ b/lib/paramedic.js
@@ -99,6 +99,9 @@ class ParamedicRunner {
                 throw new Error(error);
             })
             .fin((result) => {
+
+                // TODO 5. Collect data and clean up
+
                 isTestPassed = result;
                 logger.normal('Completed tests at ' + (new Date()).toLocaleTimeString());
 
@@ -204,6 +207,9 @@ class ParamedicRunner {
     }
 
     runLocalTests () {
+
+        // TODO 3b. locally
+
         let runProcess = null;
 
         // checking for Android platform here because in this case we still need to start an emulator
@@ -273,6 +279,9 @@ class ParamedicRunner {
     }
 
     runAppiumTests (useSauce) {
+
+        // TODO 4. Run Appium tests
+
         const platform = this.config.getPlatformId();
         logger.normal('Start running Appium tests...');
 
@@ -337,6 +346,8 @@ class ParamedicRunner {
     runTests () {
         let isTestPassed = false;
 
+        // TODO 3. Run (Jasmine) tests...
+
         // Sauce Labs
         if (this.config.shouldUseSauce()) {
             return this.paramedicSauceLabs.runSauceTests.apply(this.paramedicSauceLabs)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org